Skip to content

[main] Update dependencies from dotnet/dotnet #10367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
<Dependencies>
<ProductDependencies>
<Dependency Name="Microsoft.NET.Sdk" Version="10.0.100-preview.7.25376.102">
<Dependency Name="Microsoft.NET.Sdk" Version="10.0.100-rc.1.25401.103">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>03fb78540de4e5b3c8874da30e60b58321956993</Sha>
<Sha>8b29a1682219da555ee27e4fdda55dc3884b316f</Sha>
</Dependency>
<Dependency Name="Microsoft.NET.ILLink.Tasks" Version="10.0.0-preview.7.25376.102">
<Dependency Name="Microsoft.NET.ILLink.Tasks" Version="10.0.0-rc.1.25401.103">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>03fb78540de4e5b3c8874da30e60b58321956993</Sha>
<Sha>8b29a1682219da555ee27e4fdda55dc3884b316f</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.App.Ref" Version="10.0.0-preview.7.25376.102">
<Dependency Name="Microsoft.NETCore.App.Ref" Version="10.0.0-rc.1.25401.103">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>03fb78540de4e5b3c8874da30e60b58321956993</Sha>
<Sha>8b29a1682219da555ee27e4fdda55dc3884b316f</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Cecil" Version="0.11.5-alpha.25376.102">
<Dependency Name="Microsoft.DotNet.Cecil" Version="0.11.5-alpha.25401.103">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>03fb78540de4e5b3c8874da30e60b58321956993</Sha>
<Sha>8b29a1682219da555ee27e4fdda55dc3884b316f</Sha>
</Dependency>
<!-- Previous .NET Android version(s) -->
<Dependency Name="Microsoft.NET.Sdk.Android.Manifest-9.0.100" Version="35.0.92">
Expand All @@ -27,13 +27,13 @@
</Dependency>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Build.Tasks.Feed" Version="10.0.0-beta.25376.102">
<Dependency Name="Microsoft.DotNet.Build.Tasks.Feed" Version="10.0.0-beta.25401.103">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>03fb78540de4e5b3c8874da30e60b58321956993</Sha>
<Sha>8b29a1682219da555ee27e4fdda55dc3884b316f</Sha>
</Dependency>
<Dependency Name="Microsoft.TemplateEngine.Authoring.Tasks" Version="10.0.100-preview.7.25376.102">
<Dependency Name="Microsoft.TemplateEngine.Authoring.Tasks" Version="10.0.100-preview.7.25401.103">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>03fb78540de4e5b3c8874da30e60b58321956993</Sha>
<Sha>8b29a1682219da555ee27e4fdda55dc3884b316f</Sha>
</Dependency>
</ToolsetDependencies>
</Dependencies>
12 changes: 6 additions & 6 deletions eng/Versions.props
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
<Project>
<!--Package versions-->
<PropertyGroup>
<MicrosoftNETSdkPackageVersion>10.0.100-preview.7.25376.102</MicrosoftNETSdkPackageVersion>
<MicrosoftNETSdkPackageVersion>10.0.100-rc.1.25401.103</MicrosoftNETSdkPackageVersion>
<MicrosoftDotnetSdkInternalPackageVersion>$(MicrosoftNETSdkPackageVersion)</MicrosoftDotnetSdkInternalPackageVersion>
<MicrosoftNETILLinkTasksPackageVersion>10.0.0-preview.7.25376.102</MicrosoftNETILLinkTasksPackageVersion>
<MicrosoftNETCoreAppRefPackageVersion>10.0.0-preview.7.25376.102</MicrosoftNETCoreAppRefPackageVersion>
<MicrosoftNETILLinkTasksPackageVersion>10.0.0-rc.1.25401.103</MicrosoftNETILLinkTasksPackageVersion>
<MicrosoftNETCoreAppRefPackageVersion>10.0.0-rc.1.25401.103</MicrosoftNETCoreAppRefPackageVersion>
<MicrosoftDotNetApiCompatPackageVersion>7.0.0-beta.22103.1</MicrosoftDotNetApiCompatPackageVersion>
<MicrosoftDotNetBuildTasksFeedPackageVersion>10.0.0-beta.25376.102</MicrosoftDotNetBuildTasksFeedPackageVersion>
<MicrosoftDotNetBuildTasksFeedPackageVersion>10.0.0-beta.25401.103</MicrosoftDotNetBuildTasksFeedPackageVersion>
<MicrosoftNETWorkloadMonoToolChainPackageVersion>$(MicrosoftNETSdkPackageVersion)</MicrosoftNETWorkloadMonoToolChainPackageVersion>
<MicrosoftNETWorkloadEmscriptenPackageVersion>$(MicrosoftNETSdkPackageVersion)</MicrosoftNETWorkloadEmscriptenPackageVersion>
<MicrosoftTemplateEngineAuthoringTasksPackageVersion>10.0.100-preview.7.25376.102</MicrosoftTemplateEngineAuthoringTasksPackageVersion>
<MicrosoftDotNetCecilPackageVersion>0.11.5-alpha.25376.102</MicrosoftDotNetCecilPackageVersion>
<MicrosoftTemplateEngineAuthoringTasksPackageVersion>10.0.100-preview.7.25401.103</MicrosoftTemplateEngineAuthoringTasksPackageVersion>
<MicrosoftDotNetCecilPackageVersion>0.11.5-alpha.25401.103</MicrosoftDotNetCecilPackageVersion>
<SystemIOHashingPackageVersion>9.0.4</SystemIOHashingPackageVersion>
<!-- Previous .NET Android version -->
<MicrosoftNETSdkAndroidManifest90100PackageVersion>35.0.92</MicrosoftNETSdkAndroidManifest90100PackageVersion>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -961,11 +961,11 @@ public void BuildAppWithManagedResourceParser()
appBuilder.BuildLogFile = "build.log";
Assert.IsTrue (appBuilder.Build (appProj, doNotCleanupOnUpdate: true),
"Normal Application Build should have succeeded.");
Assert.IsTrue (appProj.CreateBuildOutput (appBuilder).IsTargetSkipped ("_ManagedUpdateAndroidResgen"),
Assert.IsTrue (appProj.CreateBuildOutput (appBuilder).IsTargetSkipped ("_ManagedUpdateAndroidResgen", defaultIfNotUsed: true),
"Target '_ManagedUpdateAndroidResgen' should not have run.");
appBuilder.BuildLogFile = "designtimebuild.log";
Assert.IsTrue (appBuilder.DesignTimeBuild (appProj, doNotCleanupOnUpdate: true), "DesignTime Application Build should have succeeded.");
Assert.IsTrue (appProj.CreateBuildOutput (appBuilder).IsTargetSkipped ("_ManagedUpdateAndroidResgen"),
Assert.IsTrue (appProj.CreateBuildOutput (appBuilder).IsTargetSkipped ("_ManagedUpdateAndroidResgen", defaultIfNotUsed: true),
"Target '_ManagedUpdateAndroidResgen' should not have run.");

Assert.IsTrue (appBuilder.Clean (appProj), "Clean should have succeeded");
Expand Down Expand Up @@ -1027,11 +1027,11 @@ public void BuildAppWithManagedResourceParserAndLibraries ()
appBuilder.ThrowOnBuildFailure = false;
Assert.IsTrue (libBuilder.DesignTimeBuild (libProj), "Library project should have built");
Assert.LessOrEqual (libBuilder.LastBuildTime.TotalMilliseconds, maxBuildTimeMs, $"DesignTime build should be less than {maxBuildTimeMs} milliseconds.");
Assert.IsFalse (libProj.CreateBuildOutput (libBuilder).IsTargetSkipped ("_ManagedUpdateAndroidResgen"),
Assert.IsFalse (libProj.CreateBuildOutput (libBuilder).IsTargetSkipped ("_ManagedUpdateAndroidResgen", defaultIfNotUsed: true),
"Target '_ManagedUpdateAndroidResgen' should have run.");
Assert.IsTrue (appBuilder.DesignTimeBuild (appProj), "Application project should have built");
Assert.LessOrEqual (appBuilder.LastBuildTime.TotalMilliseconds, maxBuildTimeMs, $"DesignTime build should be less than {maxBuildTimeMs} milliseconds.");
Assert.IsFalse (appProj.CreateBuildOutput (appBuilder).IsTargetSkipped ("_ManagedUpdateAndroidResgen"),
Assert.IsFalse (appProj.CreateBuildOutput (appBuilder).IsTargetSkipped ("_ManagedUpdateAndroidResgen", defaultIfNotUsed: true),
"Target '_ManagedUpdateAndroidResgen' should have run.");
var designerFile = Path.Combine (Root, path, appProj.ProjectName, appProj.IntermediateOutputPath, "designtime", "Resource.designer.cs");
FileAssert.Exists (designerFile, $"'{designerFile}' should have been created.");
Expand All @@ -1046,11 +1046,11 @@ public void BuildAppWithManagedResourceParserAndLibraries ()
StringAssert.DoesNotContain ("main_text_item_size", designerContents, $"{designerFile} should not contain Resources.Dimension.main_text_item_size");
StringAssert.DoesNotContain ("theme_devicedefault_background", designerContents, $"{designerFile} should not contain Resources.Color.theme_devicedefault_background");
Assert.IsTrue (libBuilder.Build (libProj), "Library project should have built");
Assert.IsTrue (libProj.CreateBuildOutput (libBuilder).IsTargetSkipped ("_ManagedUpdateAndroidResgen"),
Assert.IsTrue (libProj.CreateBuildOutput (libBuilder).IsTargetSkipped ("_ManagedUpdateAndroidResgen", defaultIfNotUsed: true),
"Target '_ManagedUpdateAndroidResgen' should not have run.");
Assert.IsTrue (appBuilder.DesignTimeBuild (appProj), "App project should have built");
Assert.LessOrEqual (appBuilder.LastBuildTime.TotalMilliseconds, maxBuildTimeMs, $"DesignTime build should be less than {maxBuildTimeMs} milliseconds.");
Assert.IsFalse (appProj.CreateBuildOutput (appBuilder).IsTargetSkipped ("_ManagedUpdateAndroidResgen"),
Assert.IsFalse (appProj.CreateBuildOutput (appBuilder).IsTargetSkipped ("_ManagedUpdateAndroidResgen", defaultIfNotUsed: true),
"Target '_ManagedUpdateAndroidResgen' should have run.");
FileAssert.Exists (designerFile, $"'{designerFile}' should have been created.");

Expand Down Expand Up @@ -1212,7 +1212,7 @@ public void CustomViewAddResourceId ()
b.Output.IsTargetPartiallyBuilt ("_CompileResources"),
"The target _CompileResources should have been partially built");
Assert.IsTrue (
b.Output.IsTargetSkipped ("_FixupCustomViewsForAapt2"),
b.Output.IsTargetSkipped ("_FixupCustomViewsForAapt2", defaultIfNotUsed: true),
"The target _FixupCustomViewsForAapt2 should have been skipped");

var r_java = Path.Combine (Root, b.ProjectDirectory, proj.IntermediateOutputPath, "android", "src", proj.PackageNameJavaIntermediatePath, "R.java");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,23 +113,23 @@ public void BindingLibraryIncremental (string classParser)

Assert.IsTrue (b.Build (proj, doNotCleanupOnUpdate: true, saveProject: false), "second build should succeed");
foreach (var target in targets) {
Assert.IsTrue (b.Output.IsTargetSkipped (target), $"`{target}` should be skipped on second build!");
Assert.IsTrue (b.Output.IsTargetSkipped (target, defaultIfNotUsed: true), $"`{target}` should be skipped on second build!");
}

Assert.IsTrue (b.DesignTimeBuild (proj, target: "UpdateGeneratedFiles"), "DTB should have succeeded.");
var cs_file = Path.Combine (Root, b.ProjectDirectory, proj.IntermediateOutputPath, "generated", "src", "Com.Larvalabs.Svgandroid.SVGParser.cs");
FileAssert.Exists (cs_file);
Assert.IsTrue (b.Build (proj, doNotCleanupOnUpdate: true, saveProject: false), "third build should succeed");
foreach (var target in targets) {
Assert.IsTrue (b.Output.IsTargetSkipped (target), $"`{target}` should be skipped on second build!");
Assert.IsTrue (b.Output.IsTargetSkipped (target, defaultIfNotUsed: true), $"`{target}` should be skipped on second build!");
}
// Fast Update Check Build
Assert.IsTrue (b.DesignTimeBuild (proj, target: "PrepareResources;_GenerateCompileInputs"), "DTB should have succeeded.");
cs_file = Path.Combine (Root, b.ProjectDirectory, proj.IntermediateOutputPath, "generated", "src", "Com.Larvalabs.Svgandroid.SVGParser.cs");
FileAssert.Exists (cs_file);
Assert.IsTrue (b.Build (proj, doNotCleanupOnUpdate: true, saveProject: false), "forth build should succeed");
foreach (var target in targets) {
Assert.IsTrue (b.Output.IsTargetSkipped (target), $"`{target}` should be skipped on second build!");
Assert.IsTrue (b.Output.IsTargetSkipped (target, defaultIfNotUsed: true), $"`{target}` should be skipped on second build!");
}

}
Expand Down Expand Up @@ -694,8 +694,8 @@ public void BindingWithAndroidJavaSource ()
"generated", "src", "Com.Xamarin.Android.Test.Msbuildtest.IJavaSourceTestInterface.cs");
StringAssertEx.ContainsText (File.ReadAllLines (generatedIface), "string GreetWithQuestion (string name, global::Java.Util.Date date, string question);");
Assert.IsTrue (libBuilder.Build (lib), "Library build should have succeeded.");
Assert.IsTrue (libBuilder.Output.IsTargetSkipped ("_CompileBindingJava"), $"`_CompileBindingJava` should be skipped on second build!");
Assert.IsTrue (libBuilder.Output.IsTargetSkipped ("_ClearGeneratedManagedBindings"), $"`_ClearGeneratedManagedBindings` should be skipped on second build!");
Assert.IsTrue (libBuilder.Output.IsTargetSkipped ("_CompileBindingJava", defaultIfNotUsed: true), $"`_CompileBindingJava` should be skipped on second build!");
Assert.IsTrue (libBuilder.Output.IsTargetSkipped ("_ClearGeneratedManagedBindings", defaultIfNotUsed: true), $"`_ClearGeneratedManagedBindings` should be skipped on second build!");
FileAssert.Exists (generatedCode, $"'{generatedCode}' should have not be deleted on second build.");
Assert.IsTrue (libBuilder.DesignTimeBuild (lib, target: "UpdateGeneratedFiles"), "DTB should have succeeded.");
FileAssert.Exists (generatedCode, $"'{generatedCode}' should have not be deleted on DTB build.");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,9 @@ public void DotNetBuild (string runtimeIdentifiers, bool isRelease, bool aot, bo

if (isRelease) {
builder.Output.AssertTargetIsNotSkipped ("ILLink");
builder.Output.AssertTargetIsSkipped ("_LinkAssembliesNoShrink");
builder.Output.AssertTargetIsSkipped ("_LinkAssembliesNoShrink", defaultIfNotUsed: true);
} else {
builder.Output.AssertTargetIsSkipped ("ILLink");
builder.Output.AssertTargetIsSkipped ("ILLink", defaultIfNotUsed: true);
builder.Output.AssertTargetIsNotSkipped ("_LinkAssembliesNoShrink");
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public void SelectivelyRunUpdateAndroidResources ()
"ProvideCommandLineArgs=true",
}), "first app build should have succeeded.");

Assert.IsTrue (appBuilder.Output.IsTargetSkipped ("UpdateAndroidResources"), $"`UpdateAndroidResources` should be skipped for DTB when deferred build is supported!");
Assert.IsTrue (appBuilder.Output.IsTargetSkipped ("UpdateAndroidResources", defaultIfNotUsed: true), $"`UpdateAndroidResources` should be skipped for DTB when deferred build is supported!");

// The background build would run our UpdateAndroidResources in its DeferredBuildDependsOn
Assert.IsTrue (appBuilder.RunTarget (app, "UpdateAndroidResources", parameters: new string[]{
Expand All @@ -42,7 +42,7 @@ public void SelectivelyRunUpdateAndroidResources ()
"ProvideCommandLineArgs=true",
}), "background build should have succeeded.");

Assert.IsFalse (appBuilder.Output.IsTargetSkipped ("UpdateAndroidResources"), $"`UpdateAndroidResources` should *not* be skipped in the deferred build!");
Assert.IsFalse (appBuilder.Output.IsTargetSkipped ("UpdateAndroidResources", defaultIfNotUsed: false), $"`UpdateAndroidResources` should *not* be skipped in the deferred build!");

// Run the real build now
Assert.IsTrue (appBuilder.Build(app, parameters: new string[]{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,7 @@ public CustomTextView(Context context, IAttributeSet attributes) : base(context,
"_CompileResources"
};
foreach (var target in aapt2TargetsShouldBeSkipped) {
Assert.IsTrue (appBuilder.Output.IsTargetSkipped (target), $"{target} should be skipped!");
Assert.IsTrue (appBuilder.Output.IsTargetSkipped (target, defaultIfNotUsed: true), $"{target} should be skipped!");
}
}
}
Expand Down Expand Up @@ -1243,15 +1243,15 @@ public void DesignTimeBuildSignAndroidPackage ()
builder.BuildLogFile = "build1.log";
Assert.IsTrue (builder.RunTarget (proj, "SignAndroidPackage", parameters: parameters), $"{proj.ProjectName} should succeed");
builder.Output.AssertTargetIsNotSkipped ("_GenerateResourceCaseMap", occurrence: 2);
builder.Output.AssertTargetIsSkipped ("_GenerateRtxt", occurrence: 1);
builder.Output.AssertTargetIsSkipped ("_GenerateRtxt", defaultIfNotUsed: true);
builder.Output.AssertTargetIsNotSkipped ("_GenerateResourceDesignerIntermediateClass");
builder.Output.AssertTargetIsSkipped ("_GenerateResourceDesignerAssembly", occurrence: 2);
builder.Output.AssertTargetIsSkipped ("_GenerateResourceDesignerAssembly", defaultIfNotUsed: true);
builder.BuildLogFile = "build2.log";
Assert.IsTrue (builder.RunTarget (proj, "SignAndroidPackage", parameters: parameters), $"{proj.ProjectName} should succeed 2");
builder.Output.AssertTargetIsNotSkipped ("_GenerateResourceCaseMap", occurrence: 3);
builder.Output.AssertTargetIsSkipped ("_GenerateRtxt", occurrence: 2);
builder.Output.AssertTargetIsSkipped ("_GenerateResourceDesignerIntermediateClass", occurrence: 2);
builder.Output.AssertTargetIsSkipped ("_GenerateResourceDesignerAssembly");
builder.Output.AssertTargetIsSkipped ("_GenerateRtxt", defaultIfNotUsed: true);
builder.Output.AssertTargetIsSkipped ("_GenerateResourceDesignerIntermediateClass", defaultIfNotUsed: true);
builder.Output.AssertTargetIsSkipped ("_GenerateResourceDesignerAssembly", defaultIfNotUsed: true);
}

[Test]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ public void ErrorIsNotRaised (string handler)
string path = Path.Combine (Root, "temp", TestName);
Directory.CreateDirectory (path);
string intermediatePath;
bool shouldSkip = handler.Contains ("Xamarin.Android.Net.AndroidMessageHandler");
bool targetSkipped;
var proj = new XamarinAndroidApplicationProject () {
IsRelease = false,
Expand All @@ -31,10 +32,10 @@ public void ErrorIsNotRaised (string handler)
b.Verbosity = LoggerVerbosity.Detailed;
b.Build (proj);
intermediatePath = Path.Combine (path,proj.IntermediateOutputPath);
targetSkipped = b.Output.IsTargetSkipped ("_CheckAndroidHttpClientHandlerType");
targetSkipped = b.Output.IsTargetSkipped ("_CheckAndroidHttpClientHandlerType", defaultIfNotUsed: shouldSkip);
}

if (handler.Contains ("Xamarin.Android.Net.AndroidMessageHandler"))
if (shouldSkip)
Assert.IsTrue (targetSkipped, "_CheckAndroidHttpClientHandlerType should not have run.");
else
Assert.IsFalse (targetSkipped, "_CheckAndroidHttpClientHandlerType should have run.");
Expand Down
Loading
Loading