Skip to content

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Oct 9, 2025

This type is used across the dashboard, not just OTLP pages.

Copy link
Contributor

github-actions bot commented Oct 9, 2025

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11920

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11920"

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves the SelectViewModel<T> class from the Aspire.Dashboard.Model.Otlp namespace to the more general Aspire.Dashboard.Model namespace, reflecting its broader usage across the dashboard beyond just OTLP-related functionality.

Key changes:

  • Moved SelectViewModel<T> to the general Model namespace
  • Updated imports across multiple components to remove the now-unnecessary Aspire.Dashboard.Model.Otlp using statements

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Aspire.Dashboard/Model/SelectViewModel.cs Changed namespace from Aspire.Dashboard.Model.Otlp to Aspire.Dashboard.Model
src/Aspire.Dashboard/Model/Interaction/InputViewModel.cs Removed unnecessary using Aspire.Dashboard.Model.Otlp statement
src/Aspire.Dashboard/Components/Dialogs/TextVisualizerDialog.razor.cs Removed unnecessary using Aspire.Dashboard.Model.Otlp statement
src/Aspire.Dashboard/Components/Controls/SpanTypeSelect.razor.cs Removed unnecessary using Aspire.Dashboard.Model.Otlp statement
src/Aspire.Dashboard/Components/Controls/SignalsActionsDisplay.razor.cs Removed unnecessary using Aspire.Dashboard.Model.Otlp statement
src/Aspire.Dashboard/Components/Controls/ResourceSelect.razor.cs Removed unnecessary using Aspire.Dashboard.Model.Otlp statement
src/Aspire.Dashboard/Components/Controls/LogLevelSelect.razor.cs Updated import from Aspire.Dashboard.Model.Otlp to Aspire.Dashboard.Model
src/Aspire.Dashboard/Components/Controls/ClearSignalsButton.razor.cs Removed unnecessary using Aspire.Dashboard.Model.Otlp statement

@JamesNK JamesNK force-pushed the jamesnk/selectviewmodel branch from 77d1adf to 0f1d0d0 Compare October 9, 2025 08:18
@JamesNK JamesNK requested a review from mitchdenny October 13, 2025 01:25
@mitchdenny mitchdenny merged commit f62b046 into main Oct 13, 2025
594 of 597 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 13.0 milestone Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants