-
Notifications
You must be signed in to change notification settings - Fork 6k
.NET Standard 2 does not support net461 #29599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
it is misleading to imply that is does when there are so many incompatibilities between the two https://www.google.com/search?q=netStandard2+net461+error
Hi @SimonCropp, THank you for posting this issue, it is much appreciated. I defer to @terrajobst on this one. From the standpoint of the docs, we were relying on Immo's interactive table as a source of truth. Immo, are you good with this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggested wording seems clearer. Thanks @SimonCropp!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple suggestions. I think it would look funny to have the superscript 2 at the start of the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I didn't realize that @SimonCropp was suggesting removing 4.6.1 from the table. I think that would be a mistake. People need to know the compatibility rules baked into NuGet because it controls which assets are selected. I think we should leave 4.6.1 there or it can result in surprises.
Co-authored-by: Genevieve Warren <[email protected]>
the point of this PR is that there are so many issues with mixing 4.6.1 with netstandard2, that having in that table is leading people down a path of pain, |
Any suggestions on how to make it clear without implying that .NET Standard 2.0 won't be seen as consumable from .NET Framework 4.6.1? How about:
FWIW, I'm not sure this table is the problem (but it's certainly part of the problem); I think the problem is that that we messed up .NET Standard 2.0 support for .NET Framework 4.6.1-4.7.1. Sadly, this is the kind of bug we can't fix without breaking even more stuff 😔 |
i get that. and i am ok with this. but given the caveats and problems people have, i think having net461 in that table does more harm than good |
it is misleading to imply that is does when there are so many incompatibilities between the two
https://www.google.com/search?q=netStandard2+net461+error
Having it as subtext is pretty poor way to communicate