Skip to content

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented May 24, 2022

it is misleading to imply that is does when there are so many incompatibilities between the two
https://www.google.com/search?q=netStandard2+net461+error

Having it as subtext is pretty poor way to communicate

While NuGet considers .NET Framework 4.6.1 as supporting .NET Standard 1.5 through 2.0, there are several issues with consuming .NET Standard libraries that were built for those versions from .NET Framework 4.6.1 projects. For .NET Framework projects that need to use such libraries, we recommend that you upgrade the project to target .NET Framework 4.7.2 or higher.

it is misleading to imply that is does when there are so many incompatibilities between the two
https://www.google.com/search?q=netStandard2+net461+error
@SimonCropp SimonCropp requested a review from a team as a code owner May 24, 2022 01:12
@IEvangelist
Copy link
Member

IEvangelist commented May 24, 2022

Hi @SimonCropp,

THank you for posting this issue, it is much appreciated. I defer to @terrajobst on this one. From the standpoint of the docs, we were relying on Immo's interactive table as a source of truth. Immo, are you good with this change?

Copy link
Contributor

@terrajobst terrajobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggested wording seems clearer. Thanks @SimonCropp!

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple suggestions. I think it would look funny to have the superscript 2 at the start of the list.

Copy link
Contributor

@terrajobst terrajobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't realize that @SimonCropp was suggesting removing 4.6.1 from the table. I think that would be a mistake. People need to know the compatibility rules baked into NuGet because it controls which assets are selected. I think we should leave 4.6.1 there or it can result in surprises.

@SimonCropp
Copy link
Contributor Author

I think we should leave 4.6.1 there or it can result in surprises.

the point of this PR is that there are so many issues with mixing 4.6.1 with netstandard2, that having in that table is leading people down a path of pain,

@terrajobst
Copy link
Contributor

terrajobst commented May 25, 2022

the point of this PR is that there are so many issues with mixing 4.6.1 with netstandard2, that having in that table is leading people down a path of pain,

Any suggestions on how to make it clear without implying that .NET Standard 2.0 won't be seen as consumable from .NET Framework 4.6.1? How about:

Framework .NET Standard 2.0
.NET Framework 4.6.1 (not really, see2) ...

FWIW, I'm not sure this table is the problem (but it's certainly part of the problem); I think the problem is that that we messed up .NET Standard 2.0 support for .NET Framework 4.6.1-4.7.1. Sadly, this is the kind of bug we can't fix without breaking even more stuff 😔

@SimonCropp
Copy link
Contributor Author

Sadly, this is the kind of bug we can't fix without breaking even more stuff

i get that. and i am ok with this. but given the caveats and problems people have, i think having net461 in that table does more harm than good

@IEvangelist IEvangelist enabled auto-merge (squash) July 11, 2022 15:01
@IEvangelist IEvangelist requested a review from terrajobst July 11, 2022 15:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants