Removed ISiloHost reference in Orleans Tutorial #29935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orleans recently switched from a specialist SiloHostBuilder, which would construct a SiloHost, to use the generic host builder (Microsoft.Extensions.Hosting.HostBuilder), which constructs an IHost. The code sample does not compile as-is, which may dissuade newcomers to Orleans. this change advises to add the Microsoft.Extensions.Hosting nuget package and updates the code sample to include the using statement and changes the ISiloHost return type to IHost. Built and tested locally successfully.
|
This looks good to me, I just want to ensure that @ReubenBond has a chance to see it and approve it as well. Thank you |
ReubenBond
approved these changes
Jun 27, 2022
|
Looks good to me, thank you @richstokoe! |
IEvangelist
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Orleans recently switched from a specialist SiloHostBuilder, which would construct a SiloHost, to use the generic host builder (Microsoft.Extensions.Hosting.HostBuilder), which constructs an IHost. The code sample does not compile as-is, which may dissuade newcomers to Orleans. this change advises to add the Microsoft.Extensions.Hosting nuget package and updates the code sample to include the using statement and changes the ISiloHost return type to IHost. Built and tested locally successfully.
Summary
Describe your changes here.
Fixes #29909