Skip to content

Clarify and update scoped service DI content #43363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2024
Merged

Clarify and update scoped service DI content #43363

merged 2 commits into from
Nov 6, 2024

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Nov 6, 2024 •
edited by github-actions bot
Loading

Summary

  • Edit pass.
  • Correct logic for scoped service resolution.

Fixes #43263

Internal previews

📄 File 🔗 Preview link
docs/core/extensions/scoped-service.md docs/core/extensions/scoped-service

@IEvangelist IEvangelist requested a review from a team as a code owner November 6, 2024 17:50
@dotnetrepoman dotnetrepoman bot added this to the November 2024 milestone Nov 6, 2024
@IEvangelist IEvangelist requested a review from adegeo November 6, 2024 17:50
@IEvangelist IEvangelist marked this pull request as draft November 6, 2024 18:01
@IEvangelist IEvangelist marked this pull request as ready for review November 6, 2024 19:38
@IEvangelist IEvangelist enabled auto-merge (squash) November 6, 2024 19:38
adegeo
adegeo approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!!!!!!!!!!!!!

Here are some more !!!!!!

@IEvangelist IEvangelist merged commit 2f080c6 into dotnet:main Nov 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adegeo adegeo adegeo approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
November 2024
Development

Successfully merging this pull request may close these issues.

Where should the while loop placed?
2 participants
@IEvangelist @adegeo