-
Notifications
You must be signed in to change notification settings - Fork 826
FCS: allow getting captured types #18878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❗ Release notes required
|
7702a51
to
58581bd
Compare
I'm stuck with the ILVerify tests due to #18289 again:
Or when trying another shell, as suggested in the devguide:
Could someone update the baselines here, please? |
I think the script is (badly) written in a way that relies on having a specific current directory, otherwise it searches in wrong folders I will do it 👍 (I think those two things should make it smoother to execute) |
/run ilverify |
🔧 CLI Command Report
✅ Patch applied: |
This has been ready since last Tuesday. I'd like to continue to work on it in subsequent PRs, but this is getting stale. |
@auduchinok if its only to update the ilverify. Happy to send a PR to your fork. If so please fix the conflicts then I will try and run the ilverify on my machine and see if that helps |
# Conflicts: # tests/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.SurfaceArea.netstandard20.release.bsl
4441521
to
70f58e1
Compare
Types of certain expressions and patterns are captured during analysis, so features like code completion could use them later. This PR adds APIs to get these types and also captures types of some additional expressions.
In comparison with working with typed tree, this approach allows getting types of various expressions even when the resulting expression could not be created due to errors in the source.
I'm planning to add more reporting in the subsequent PRs. It would also be nice to revive #8828.