[devops] Hide comments when commit being built isn't the last commit in PR #23043

Copilot · 2025-06-13T14:51:01Z

This PR implements the functionality to automatically hide CI comments when the commit being built is not the latest commit in the pull request, helping to keep PR conversations clean by only showing the most recent CI results.

Changes Made

New Methods Added

IsCurrentCommitLatestInPR() - Checks if the current commit matches the head commit of the PR using the GitHub API
HideNewlyPostedComment() - Helper method to find and minimize recently posted comments

Modified Comment Posting Logic

Updated all comment posting methods (NewCommentFromMessage, NewCommentFromObject, NewCommentFromFile) to:

Only hide previous comments if the current commit is the latest in the PR
Hide the newly posted comment immediately if the current commit is NOT the latest in the PR

Behavior Changes

Before: All CI comments were posted visibly, with previous comments always hidden when posting new ones.

After:

Latest commit builds: Normal behavior - post visible comment, hide previous comments
Older commit builds: Post comment but immediately hide it, preserve previous visible comments

Example Scenarios

Building latest commit in PR: Comment posted normally, previous comments hidden ✅
Building older commit in PR (e.g., due to CI retry or queue delay): Comment posted but immediately hidden, previous comments remain visible ✅
Building non-PR commits: Normal behavior unchanged ✅

Testing

Added comprehensive tests for the new functionality in GitHub.Tests.ps1
Verified PowerShell syntax correctness and module import
Tested logic with various PR scenarios (latest commit, older commit, non-PR)

The implementation ensures that users only see CI results for the most current state of their PR while still preserving all CI history in the hidden comments.

Fixes #23042.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/repos/testorg/testrepo/commits/testhash/pulls
- Triggering command: pwsh /tmp/test_module_import.ps1 (http block)
www.powershellgallery.com
- Triggering command: pwsh -Command Install-Module -Name Pester -Force -Scope CurrentUser (dns block)
- Triggering command: pwsh -Command Set-PSRepository psgallery -InstallationPolicy trusted; Install-Module -Name Pester -Confirm:$false -Force (dns block)
- Triggering command: pwsh -Command Get-PSRepository (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to my firewall allow list

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: rolfbjarne <[email protected]>

Copilot · 2025-06-13T15:32:26Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 3d8f5ac7-fc91-4dbf-8d94-80937098c214

Sorry for the inconvenience!

Copilot · 2025-06-13T15:41:41Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 86a1cd96-bf6c-4812-910f-32747856a112

Sorry for the inconvenience!

Copilot · 2025-06-13T15:58:51Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 73aca4d4-28b5-409e-944e-e432eca2cffc

Sorry for the inconvenience!

Copilot · 2025-06-13T16:14:01Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 7354287d-5bcb-4ba8-b24f-8541ee03c870

Sorry for the inconvenience!

Copilot · 2025-06-13T16:24:21Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: a36c0c28-4511-461e-a165-2430356f9539

Sorry for the inconvenience!

Copilot · 2025-06-13T16:29:10Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 95bbec55-00bb-4935-8098-b0830aaddc2f

Sorry for the inconvenience!

Copilot · 2025-06-13T16:29:55Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: c57d2e96-2438-4137-9486-5a5ac150effd

Sorry for the inconvenience!

Copilot · 2025-06-13T16:31:01Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 2ac712f0-7319-4ce3-97ad-48733064ced5

Sorry for the inconvenience!

mandel-macaque · 2025-06-13T18:55:27Z

tools/devops/automation/scripts/GitHub.psm1

+        foreach ($c in $prComments) {
+            if ($c.Body.Contains($commentIdentifier)) {
+                # This could be our comment or a previous one, but let's check if it's recent
+                # We'll minimize any comment with our identifier that's from the bot and not already minimized
+                if ($c.Author -eq "vs-mobiletools-engineering-service2" -and -not $c.IsMinimized) {
+                    Write-Host "Found recently posted comment to minimize: $($c.Id)"
+                    $this.MinimizeComments(@($c))
+                    break
+                }
+            }
+        }


Use a nicer variable name, rather than 'c' use 'comment'

Fixed in commit 253edf5. Changed the variable name from 'c' to 'comment' in the foreach loop for better readability.

tools/devops/automation/scripts/GitHub.psm1

mandel-macaque · 2025-06-13T18:58:18Z

tools/devops/automation/scripts/GitHub.psm1

+        $result = $this.NewComment($msg)
+
+        # If this commit is not the latest in the PR, hide this comment immediately
+        if ($this.IsPR() -and -not $this.IsCurrentCommitLatestInPR()) {


You use this if statement in several places, can you make it a function and reuse the logic rather than copy paste it over an over?

Refactored in commit 253edf5. Created two helper methods - HandlePreviousCommentHiding() and HandleNewCommentHiding() - to eliminate the duplicate conditional logic across all three NewCommentFrom* methods. This reduces code duplication and makes the logic easier to maintain.

…g, and extract duplicate logic Co-authored-by: mandel-macaque <[email protected]>

Copilot · 2025-06-13T19:10:09Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/repos/testorg/testrepo/commits/testhash/pulls
- Triggering command: pwsh -Command Import-Module ./tools/devops/automation/scripts/GitHub.psm1 -Force $gh = New-GitHubCommentsObject -Org 'testorg' -Repo 'testrepo' -Token 'testtoken' -Hash 'testhash' Write-Host 'GitHubComments object created successfully' Write-Host 'IsCurrentCommitLatestInPR method exists:' ($gh | Get-Member -Name 'IsCurrentCommitLatestInPR') Write-Host 'HideNewlyPostedComment method exists:' ($gh | Get-Member -Name 'HideNewlyPostedComment') Write-Host 'HandlePreviousCommentHiding method exists:' ($gh | Get-Member -Name 'HandlePreviousCommentHiding') Write-Host 'HandleNewCommentHiding method exists:' ($gh | Get-Member -Name 'HandleNewCommentHiding') (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to my firewall allow list

Copilot · 2025-06-26T12:27:03Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: e3adaa01-e47a-4801-979a-1f4ab85aa514

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-06-26T17:32:05Z

✅ [CI Build #10a9850] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 10a9850d4861686666877224573d6c4cb7310249 [PR build]

Copilot · 2025-06-26T17:32:09Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 8f5d51bc-20d2-4cd8-aa15-97d7a215a859

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-06-26T17:33:41Z

✅ [PR Build #10a9850] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 10a9850d4861686666877224573d6c4cb7310249 [PR build]

Copilot · 2025-06-26T17:33:45Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 9e85dde2-dfae-42de-9d8a-ed708ac67ee4

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-06-26T18:05:55Z

✅ [CI Build #10a9850] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 10a9850d4861686666877224573d6c4cb7310249 [PR build]

Copilot · 2025-06-26T18:06:00Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 37afcb8c-f85d-4f4f-9f75-e759dd8c7e1c

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-06-26T18:16:16Z

💻 [CI Build #10a9850] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 10a9850d4861686666877224573d6c4cb7310249 [PR build]

Copilot · 2025-06-26T18:16:20Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 11270b9c-f45f-4ac3-bb81-cc3a75bc4c2a

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-06-26T18:19:35Z

💻 [CI Build #10a9850] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 10a9850d4861686666877224573d6c4cb7310249 [PR build]

Copilot · 2025-06-26T18:19:42Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 1e36735a-32e5-4cb2-a65e-38077f9906c5

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-06-26T18:20:57Z

💻 [CI Build #10a9850] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 10a9850d4861686666877224573d6c4cb7310249 [PR build]

Copilot · 2025-06-26T18:21:01Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: c5a7b2e9-989e-48b5-91b1-1d5f02b294cf

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-06-26T18:21:02Z

💻 [CI Build #10a9850] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 10a9850d4861686666877224573d6c4cb7310249 [PR build]

Copilot · 2025-06-26T18:21:06Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 9b83a4f5-418b-45a0-b70f-35f511fdc56c

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-06-26T18:22:49Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 10a9850d4861686666877224573d6c4cb7310249 [PR build]

Copilot · 2025-06-26T18:22:54Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 6fbed271-6529-4a0b-80b6-ec028d35f754

Sorry for the inconvenience!

Copilot · 2025-06-26T20:31:52Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 8dde9b40-9f90-4f2d-97ff-4e18a2bb7447

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-06-27T12:09:50Z

🚀 [CI Build #10a9850] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 10a9850d4861686666877224573d6c4cb7310249 [PR build]

Copilot · 2025-06-27T12:09:54Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: a9e8f95e-5137-4ebe-a7e2-19584c45e194

Sorry for the inconvenience!

Initial plan for issue

b091f06

Copilot AI assigned Copilot and rolfbjarne Jun 13, 2025

Copilot started work on behalf of rolfbjarne June 13, 2025 14:51 View session

Copilot AI and others added 2 commits June 13, 2025 14:58

Add logic to hide CI comments when commit is not latest in PR

07a6339

Co-authored-by: rolfbjarne <[email protected]>

Fix PowerShell variable syntax in Write-Host statement

c497643

Copilot AI changed the title ~~[WIP] CI: if adding comments to a PR, add it hidden if the commit being built isn't the last commit in the PR~~ CI: Hide comments when commit being built isn't the last commit in PR Jun 13, 2025

Copilot AI requested a review from rolfbjarne June 13, 2025 15:05

Copilot finished work on behalf of rolfbjarne June 13, 2025 15:05

This comment has been minimized.

Sign in to view

mandel-macaque requested changes Jun 13, 2025

View reviewed changes

Copilot started work on behalf of mandel-macaque June 13, 2025 18:58 View session

Address PR review feedback: Add documentation, improve variable namin…

253edf5

…g, and extract duplicate logic Co-authored-by: mandel-macaque <[email protected]>

Copilot finished work on behalf of mandel-macaque June 13, 2025 19:10

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/main' into copilot/fix-23042

10a9850

This comment has been minimized.

Sign in to view

rolfbjarne changed the title ~~CI: Hide comments when commit being built isn't the last commit in PR~~ [devops] Hide comments when commit being built isn't the last commit in PR Jun 27, 2025

rolfbjarne marked this pull request as ready for review July 10, 2025 10:49

dalexsoto approved these changes Jul 10, 2025

View reviewed changes

rolfbjarne approved these changes Jul 10, 2025

View reviewed changes

mcumming approved these changes Jul 10, 2025

View reviewed changes

rolfbjarne merged commit 41ccc9d into main Jul 10, 2025
44 checks passed

rolfbjarne deleted the copilot/fix-23042 branch July 10, 2025 14:51

[devops] Hide comments when commit being built isn't the last commit in PR #23043

[devops] Hide comments when commit being built isn't the last commit in PR #23043

Uh oh!

Conversation

Copilot AI commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made

New Methods Added

Modified Comment Posting Logic

Behavior Changes

Example Scenarios

Testing

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 13, 2025

Uh oh!

mandel-macaque Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mandel-macaque Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jun 13, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

This comment has been minimized.

Copilot AI commented Jun 26, 2025

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 26, 2025

✅ [CI Build #10a9850] Build passed (Build packages) ✅

Uh oh!

Copilot AI commented Jun 26, 2025

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 26, 2025

✅ [PR Build #10a9850] Build passed (Detect API changes) ✅

Uh oh!

Copilot AI commented Jun 26, 2025

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 26, 2025

✅ [CI Build #10a9850] Build passed (Build macOS tests) ✅

Uh oh!

Copilot AI commented Jun 26, 2025

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 26, 2025

💻 [CI Build #10a9850] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

Copilot AI commented Jun 26, 2025

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 26, 2025

💻 [CI Build #10a9850] Tests on macOS M1 - Mac Monterey (12) passed 💻

Copilot AI commented Jun 13, 2025 •

edited

Loading