-
Notifications
You must be signed in to change notification settings - Fork 548
[msbuild] Use shorter intermediate paths when extracting files from compressed binding project sidecars. Mitigates #23346. #23639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ompressed binding project sidecars. Mitigates #23346. * When decompressing a .framework from inside a compressed .xcframework, simplify the on-disk location of the decompressed files so that the location is shorter, in an attempt to not run into MAX_PATH issues on Windows. Example: For the xcframework XTest.xcframework, we'd previously extract the framework `XTest.xcframework/ios-arm64_x86_64-maccatalyst/XTest.framework` into: $(DeviceSpecificIntermediateOutputPath)/XTest.xcframework/ios-arm64_x86_64-maccatalyst/XTest.framework while we now extract into: $(DeviceSpecificIntermediateOutputPath)/XTest.framework [FIXME: fix paths to be real] * Also add support for filtering to not extract certain files from an xcframework. This can be used to filter out header files, Swift modules, etc. Mitigates #23346.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #e16e76c] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #e16e76c] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )✅ API diff vs stable.NET ( No breaking changes )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )✅ API diff vs stable.NET ( No breaking changes )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #e16e76c] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #e16e76c] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #e16e76c] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #e16e76c] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #e16e76c] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #e16e76c] Test results 🔥Test results❌ Tests failed on VSTS: test results 2 tests crashed, 1 tests failed, 111 tests passed. Failures❌ monotouch tests (iOS) [attempt 2]🔥 Failed catastrophically on VSTS: test results - monotouch_ios (no summary found). Html Report (VSDrops) Download ❌ windows tests [attempt 2]Html Report (VSDrops) Download ❌ xcframework tests [attempt 2]🔥 Failed catastrophically on VSTS: test results - xcframework (no summary found). Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
TODO
When decompressing a .framework from inside a compressed .xcframework, simplify
the on-disk location of the decompressed files so that the location is shorter,
in an attempt to not run into MAX_PATH issues on Windows.
Example:
For the xcframework XTest.xcframework, we'd previously extract the framework
XTest.xcframework/ios-arm64_x86_64-maccatalyst/XTest.framework
into:$(DeviceSpecificIntermediateOutputPath)/XTest.xcframework/ios-arm64_x86_64-maccatalyst/XTest.framework
while we now extract into:
[FIXME: fix paths to be real]
This can be used to filter out header files, Swift modules, etc.
Mitigates #23346.