Skip to content

Conversation

rolfbjarne
Copy link
Member

TODO

  • Fix FIXME in description below
  • Remove debugging code.

  • When decompressing a .framework from inside a compressed .xcframework, simplify
    the on-disk location of the decompressed files so that the location is shorter,
    in an attempt to not run into MAX_PATH issues on Windows.

    Example:

    For the xcframework XTest.xcframework, we'd previously extract the framework XTest.xcframework/ios-arm64_x86_64-maccatalyst/XTest.framework into:

    $(DeviceSpecificIntermediateOutputPath)/XTest.xcframework/ios-arm64_x86_64-maccatalyst/XTest.framework

    while we now extract into:

    $(DeviceSpecificIntermediateOutputPath)/XTest.framework
    

[FIXME: fix paths to be real]

  • Also add support for filtering to not extract certain files from an xcframework.
    This can be used to filter out header files, Swift modules, etc.

Mitigates #23346.

rolfbjarne and others added 2 commits August 19, 2025 15:29
…ompressed binding project sidecars. Mitigates #23346.

* When decompressing a .framework from inside a compressed .xcframework, simplify
  the on-disk location of the decompressed files so that the location is shorter,
  in an attempt to not run into MAX_PATH issues on Windows.

  Example:

  For the xcframework XTest.xcframework, we'd previously extract the framework `XTest.xcframework/ios-arm64_x86_64-maccatalyst/XTest.framework` into:

     $(DeviceSpecificIntermediateOutputPath)/XTest.xcframework/ios-arm64_x86_64-maccatalyst/XTest.framework

  while we now extract into:

      $(DeviceSpecificIntermediateOutputPath)/XTest.framework

[FIXME: fix paths to be real]

* Also add support for filtering to not extract certain files from an xcframework.
  This can be used to filter out header files, Swift modules, etc.

Mitigates #23346.
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #e16e76c] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: e16e76ce924f4a8a6402b7ea5bf5ea3b9c204f6c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #e16e76c] Build passed (Build packages) ✅

Pipeline on Agent
Hash: e16e76ce924f4a8a6402b7ea5bf5ea3b9c204f6c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: e16e76ce924f4a8a6402b7ea5bf5ea3b9c204f6c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 4752ecefc2733c57237a7f06a66ff1f336acaf02 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #e16e76c] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: e16e76ce924f4a8a6402b7ea5bf5ea3b9c204f6c [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #e16e76c] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: e16e76ce924f4a8a6402b7ea5bf5ea3b9c204f6c [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #e16e76c] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: e16e76ce924f4a8a6402b7ea5bf5ea3b9c204f6c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #e16e76c] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: e16e76ce924f4a8a6402b7ea5bf5ea3b9c204f6c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #e16e76c] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: e16e76ce924f4a8a6402b7ea5bf5ea3b9c204f6c [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build #e16e76c] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

2 tests crashed, 1 tests failed, 111 tests passed.

Failures

❌ monotouch tests (iOS) [attempt 2]

🔥 Failed catastrophically on VSTS: test results - monotouch_ios (no summary found).

Html Report (VSDrops) Download

❌ windows tests [attempt 2]

1 tests failed, 0 tests passed.

Html Report (VSDrops) Download

❌ xcframework tests [attempt 2]

🔥 Failed catastrophically on VSTS: test results - xcframework (no summary found).

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: e16e76ce924f4a8a6402b7ea5bf5ea3b9c204f6c [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants