Skip to content

Conversation

@kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Oct 24, 2025

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

Updated the NavigationRenderer on iOS to account for IView margins when calculating the layout rectangle. This ensures that child views are positioned and sized correctly according to their margin properties.

  <NavigationPage.TitleView>
        <HorizontalStackLayout BackgroundColor="Blue"
                HorizontalOptions="Fill"
                VerticalOptions="Fill"
                Margin="-20,0,0,0">
            <Label Text="1234567890abcdefghij"/>
        </HorizontalStackLayout>
    </NavigationPage.TitleView>
Before After

Issues Fixed

Fixes #32200

Updated the NavigationRenderer on iOS to account for IView margins when calculating the layout rectangle. This ensures that child views are positioned and sized correctly according to their margin properties.
@Copilot Copilot AI review requested due to automatic review settings October 24, 2025 23:42
@kubaflo kubaflo changed the base branch from main to net10.0 October 24, 2025 23:42
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Oct 24, 2025
@dotnet-policy-service
Copy link
Contributor

Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates BlazorWebView implementations across iOS, Windows, and Android platforms, along with extensive localization file updates. The changes primarily focus on refactoring web resource request handling, adding unsafe code support, fixing API compatibility issues, and updating localization strings across multiple languages.

Key Changes

  • Refactored web resource request interception to use a unified pattern across platforms
  • Added unsafe code blocks support for iOS-specific interop requirements
  • Fixed iOS API compatibility issues by implementing custom trampoline blocks
  • Updated localization files across multiple languages (Chinese, Turkish, Russian, Portuguese, Polish, Korean, Spanish)

Reviewed Changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/BlazorWebView/src/Maui/iOS/IOSWebViewManager.cs Implemented custom ActionStringTrampolineBlock for iOS API compatibility and updated JavaScript method signatures
src/BlazorWebView/src/Maui/iOS/BlazorWebViewHandler.iOS.cs Added WebView scroll bounce disabling and web resource request interception
src/BlazorWebView/src/Maui/Windows/WinUIWebViewManager.cs Refactored request handling with unified interception pattern
src/BlazorWebView/src/Maui/Android/* Refactored Android WebView clients to support web resource interception
src/BlazorWebView/src/Maui/Microsoft.AspNetCore.Components.WebView.Maui.csproj Enabled unsafe code blocks and removed unused file reference
src/BlazorWebView/src/Maui/IBlazorWebView.cs Extended interface to implement IWebRequestInterceptingWebView
src/BlazorWebView/src/Maui/BlazorWebView.cs Implemented WebResourceRequested event handling
src/BlazorWebView/src/Maui/PublicAPI/*/PublicAPI.Unshipped.txt Added new WebResourceRequested event to public API surface
src/BlazorWebView/samples/* Updated project configurations for WPF/WinForms samples
loc/** Updated localization strings across multiple languages for templates and resources

@kubaflo kubaflo changed the title Net 26 navbar margins [iOS26] Apply view margins in title view Oct 24, 2025
@kubaflo kubaflo self-assigned this Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant