Extend the "skip-test" optimization to all instructions that modify the #120876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the "skip-test" optimization to all instructions that modify the same flags as "TEST" x86 instruction
Originally wanted to only cover the "POPCNT" case, but actually we can go further than that and cover more instructions.
Fixes #118811
Using the following code:
This fix reduces this assembly:
to this assembly:
Note: this is not exactly as was intended in the issue, where a
jne
was expected. But that should be good enough.Note2: this does not affect
tnzcnt
orlzcnt
instructions as these instructions do not modify the flags.