Use programatically check instead of assertion in method ComputeVisibleColumns of DataGridView.Methods to avoid null reference exception #13739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13728
Root Cause
Due to this commit 9cbce69 (line 4827), the exception thrown on .net10.0 is
System.InvalidOperationException
, and the exception thrown on .net8.0 isNullReferenceException
.The original code does not make a null judgment but adds an assertion without verifying whether
GetPreviousColumn(...)
returned a valid column. In cases where:dataGridViewColumn would be null, triggering an exception and terminating rendering.
Proposed changes
ComputeVisibleColumns
ofDataGridView.Methods
to avoid null reference exceptionCustomer Impact
Regression?
Risk
Screenshots
Before
Setting DataGridViewColumn.Visible may throw NullReferenceException
BeforeChange.mp4
After
The rightmost visible column can also be successfully hidden.
AfterChange.mp4
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow