Skip to content

Fix InvalidCastException in ComboBoxAutomationPeer / forward Scroll to ItemsControl #10877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix InvalidCastException in ComboBoxAutomationPeer / forward Scroll to ItemsControl #10877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions ...t.Wpf/src/PresentationFramework/System/Windows/Automation/Peers/ComboBoxAutomationPeer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,27 +37,20 @@ protected override string GetClassNameCore()
///
public override object GetPattern(PatternInterface pattern)
{
object iface = null;
ComboBox owner = (ComboBox)Owner;

if (pattern == PatternInterface.Value)
if ((pattern is PatternInterface.Value && owner.IsEditable) || pattern is PatternInterface.ExpandCollapse)
{
if (owner.IsEditable) iface = this;
return this;
}
else if(pattern == PatternInterface.ExpandCollapse)
{
iface = this;
}
else if (pattern == PatternInterface.Scroll && !owner.IsDropDownOpen)
{
iface = this;
}
else

if (pattern is PatternInterface.Scroll && !owner.IsDropDownOpen)
{
iface = base.GetPattern(pattern);
return null;
}

return iface;
// PatternInterface.Scroll is handled by ItemsControlAutomationPeer when Expanded/DropDown is open
return base.GetPattern(pattern);
}

///
Expand Down