refactor(client): replace sync.WaitGroup with wg.Go #4297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jinronga Please fix the CI. |
jinronga
force-pushed
the
feat/go1.25
branch
2 times, most recently
from
663890a to
ba234be
Compare
- Replace instances of sync.WaitGroup with wg.Go for simpler concurrency management - Update multiple files across the client directory to use the new wg.Go pattern - This change improves code readability and reduces boilerplate in concurrent code Signed-off-by: “jinrong” <[email protected]> Signed-off-by: jinronga <[email protected]>
- Update Go version from 1.23.8 to 1.25 in Dockerfiles and build script - Simplify build command in scheduler Dockerfile - Remove redundant 'server-builder' stage in manager Dockerfile Signed-off-by: “jinrong” <[email protected]> Signed-off-by: jinronga <[email protected]>
- Update BASE_IMAGE to alpine3.22 in Dockerfiles for dfdaemon, manager, scheduler, and plugin-builder - Update builder image to golang:1.25-alpine3.22 for dfdaemon - Update builder image to golang:1.25-alpine3.20 for scheduler (keeping alpine3.20 for consistency with other changes) - Update BASE_IMAGE to alpine3.22 in hack/docker-build.sh Signed-off-by: “jinrong” <[email protected]> Signed-off-by: jinronga <[email protected]>
- Enhance error messages with more context and consistency - Optimize logging format for errors in peer task conductor and related components - Improve error recording in trace spans - Simplify error handling in various peer task functions Signed-off-by: “jinrong” <[email protected]> Signed-off-by: jinronga <[email protected]>
…pieceManager - Consolidate error messages for content length mismatches in peerTaskConductor - Simplify error creation in pieceManager for source response validation - Enhance logging consistency and clarity across error handling Signed-off-by: jinronga <[email protected]>
- Update BASE_IMAGE to alpine3.20 in Dockerfiles for dfdaemon, manager, scheduler, and plugin-builder - Adjust builder image to golang:1.25-alpine3.20 for consistency across Dockerfiles - Modify hack/docker-build.sh to reflect the new base image Signed-off-by: jinronga <[email protected]>
- Upgrade GOLANG_VERSION from 1.23.8 to 1.25.0 - Update GOLANG_DOWNLOAD_URL and GOLANG_DOWNLOAD_SHA256 for the new version Signed-off-by: jinronga <[email protected]>
- Change builder image from golang:1.25-alpine3.20 to golang:1.25.0 for dfdaemon, manager, scheduler, and plugin-builder Dockerfiles - Mark client-rs subproject as dirty Signed-off-by: jinronga <[email protected]>
Signed-off-by: jinronga <[email protected]>
Signed-off-by: jinronga <[email protected]>
Signed-off-by: jinronga <[email protected]>
Signed-off-by: jinronga <[email protected]>
jinronga
force-pushed
the
feat/go1.25
branch
from
9b7385f to
2d0d40a
Compare
|
@jinronga Please fix lint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist