Skip to content

Conversation

flaneur2020
Copy link

@flaneur2020 flaneur2020 commented Sep 17, 2025

Description

this pr renamed struct field from Multiplex to Reuse in StorageOption and TaskManagerOption.

this is a small renaming in the inner implementation, the field name in the config is still not changed to keep backward compatibility.

Related Issue

Motivation and Context

the term "Multiplex" was a bit misleading in the context of this feature. the functionality actually deals with reusing underlying storage for tasks with the same ID, not multiplexing in the traditional networking sense (in IO or channels).

the term "Reuse" is kinda more accurately describes what the feature does: it enables the system to reuse cached data from completed peer tasks rather than re-downloading them. the existing code already uses the "reuse" term in the implementation, and this pr tries renaming the struct fields to align with the implementation.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)
  • Small renaming

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Sep 18, 2025
@gaius-qi gaius-qi added this to the v2.4.0 milestone Sep 18, 2025
gaius-qi
gaius-qi previously approved these changes Sep 18, 2025
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chlins
chlins previously approved these changes Sep 18, 2025
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins enabled auto-merge (squash) September 18, 2025 02:37
auto-merge was automatically disabled September 18, 2025 09:31

Head branch was pushed to by a user without write access

@flaneur2020 flaneur2020 dismissed stale reviews from chlins and gaius-qi via d471c86 September 18, 2025 09:31
@chlins chlins enabled auto-merge (squash) September 24, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants