gui: Add support to configure the connection device from the CLI #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I find sometimes I'm closing and opening the gui, connecting to the same serial port. |
dakejahl
reviewed
Jun 20, 2025
joshanne
force-pushed
the
pr/specify-connection-at-command-line
branch
from
9cb83f1 to
2c1542c
Compare
Allows the user to predefine the connection device by using: dronecan_gui_tool.py --interface <device-name> Also allows to preconfigure some of the other args in the setup window, so a user preconfigure and select only the device they care about.
joshanne
force-pushed
the
pr/specify-connection-at-command-line
branch
from
2c1542c to
65bfbbb
Compare
joshanne
commented
Jun 23, 2025
|
@peterbarker @tridge any chance you can take a review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to predefine the connection device by using:
dronecan_gui_tool.py --master
Also allows to preconfigure some of the other args in the setup window, so a user preconfigure and select only the device they care about.