Skip to content

Allow overrides in the vendor specific data type DSDL ID range #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wiboticalex
Copy link

This pull request allows overriding DSDL definitions with ones that come latest on the path list when in the "Vendor-specific messages types" range indicated at https://dronecan.github.io/Specification/5._Application_level_conventions/.

With this, I can now add DSDLs with conflicting IDs to my uavcan_vendor_specific_types directory and decode the DSDLs as expected (as was the behavior back when we were using UAVCAN V0 when the DSDL repository didn't define anything in the vendor specific range).

I think this is a reasonable approach since there are only ever 999 IDs allocated for Vendors, so the chance of collisions with existing DSDLs is relatively high as new public DSDLs become available. However, I would also be fine with a strategy such as the one called out in #30 since that would allow me to avoid the conflicting IDs in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant