Skip to content

createdAt should not be created into db #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

createdAt should not be created into db #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 25 additions & 26 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,19 +40,17 @@ function timestampsPlugin(schema, options) {
dataObj[updatedAt] = updatedAtOpts;
}

if (schema.path(createdAt)) {
if (!schema.path(updatedAt) && updatedAt) {
schema.add(dataObj);
}
if (schema.virtual(createdAt).get) {
schema.virtual(createdAt)
.get( function () {
if (this["_" + createdAt]) return this["_" + createdAt];
return this["_" + createdAt] = this._id.getTimestamp();
});
}
function setupCreatedVirtual(){
schema.virtual(createdAt)
.get( function () {
if (this["_" + createdAt]) return this["_" + createdAt];
return this["_" + createdAt] = this._id.getTimestamp();
});
}

function setupPreSave(condition,createdAt){
schema.pre('save', function(next) {
if (this.isNew) {
if (condition(this)) {
var newDate = new Date;
if (createdAt) this[createdAt] = newDate;
if (updatedAt) this[updatedAt] = newDate;
Expand All @@ -61,24 +59,25 @@ function timestampsPlugin(schema, options) {
}
next();
});
}

} else {
if (createdAt) {
dataObj[createdAt] = createdAtOpts;
if (schema.path(createdAt)) {
if (!schema.path(updatedAt) && updatedAt) {
schema.add(dataObj);
}
if (dataObj[createdAt] || dataObj[updatedAt]) {

if (schema.virtual(createdAt).get) {
setupCreatedVirtual();
}

setupPreSave(function(that){return that.isNew; },createdAt); //Also update createdAt

} else {
if (dataObj[updatedAt]) {
schema.add(dataObj);
}
schema.pre('save', function(next) {
if (!this[createdAt]) {
var newDate = new Date;
if (createdAt) this[createdAt] = newDate;
if (updatedAt) this[updatedAt] = newDate;
} else if (this.isModified() && updatedAt) {
this[updatedAt] = new Date;
}
next();
});
setupPreSave(function(that){return !that[createdAt]; }); //do not create createdAt in db, so undefined in second parameter
setupCreatedVirtual();
}

schema.pre('findOneAndUpdate', function(next) {
Expand Down