秦丹一项目提交 #3
秦丹一项目提交 #3
Conversation
秦丹一/data-analysis/public/index.html
Outdated
There was a problem hiding this comment.
在编辑器安装 prettiter 相关插件，并设置保存时自动格式化，避免这种问题
秦丹一/data-analysis/src/App.tsx
Outdated
|
收到
发自我的iPhone
…------------------ 原始邮件 ------------------
发件人: Zihang Zhang ***@***.***>
发送时间: 2021年10月15日 16:08
收件人: dt-fe/dt-fe-training ***@***.***>
抄送: asterism-q ***@***.***>, Author ***@***.***>
主题: 回复：[dt-fe/dt-fe-training] 秦丹一项目提交 (#3)
@Hungrated commented on this pull request.
In 秦丹一/data-analysis/src/components/ComplexSelect/index.tsx:
> @@ -0,0 +1,64 @@ +import React, { useState, useContext } from 'react' +// import { getOverall } from '../../service'; +import styles from './index.module.scss'; +import up from '../../images/up.svg' +import down from '../../images/down.svg' +import { percentFormat, numberFormat, handleSelect } from '../../utils' +import { OverallContext } from '../../pages/Home/index' + + +export default function ComplexSelect() { + + const { selectedList, setSelectedList, + overallData, setOverallData
代码格式化一下
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
There was a problem hiding this comment.
一般来说，组件声明应规范化，比如加上强类型
const Component: React.FC<Props> = React.memo((props: Props) => {
return xxx;
})
There was a problem hiding this comment.
pageFlag * 10 及 pageFlag * 10 + maxOfpage - 1 等，建议在组件头部声明语义化的变量
slice 的结果也可以语义化声明出来，增加代码可读性
There was a problem hiding this comment.
数组判空，使用 lodash
_.isEmpty(renderList)
There was a problem hiding this comment.
数组迭代逻辑一般无需使用 for 循环。
推荐使用 ES6 的 Array.prototype.map 和 Array.prototype.reduce；其他API也可以了解下，如 filter some every forEach等 都比较常用
https://developer.mozilla.org/zh-CN/docs/Web/JavaScript/Reference/Global_Objects/Array/map
There was a problem hiding this comment.
pop 方法会改变 selectedGoodsList 本身，不符合 React 数据流中的 immutable 原则；
这里可以直接根据需求在下一行 slice(0, _.size(selectedGoodsList)-1) 去掉最后一个，或 slice(1) 去掉第一个
秦丹一/data-analysis/src/service.ts
Outdated
There was a problem hiding this comment.
const baseUrl = 'http://120.26.194.171:3000/v1';
3 participants
No description provided.