Sts profile v1.3 #102
Merged
Sts profile v1.3 #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tmonster
force-pushed
the
sts-profile-v1.3
branch
from
cca51b6 to
b9425a8
Compare
samansmink
approved these changes
Sep 2, 2025
This was referenced Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates how we handle STS roles with aws credentials.
This PR updates it so the rules are as follows
STScan be used if and only ifASSUME_ROLE_ARNis also presentchain, the requested profile is first loaded. If the requested profile has arole-arnvalue, then aSTSAssumeRoleCredentialsProvideris used to load credentials. This does not break the current functionality since assuming a role within the config file would not workAws::Auth::DefaultAWSCredentialsProviderChain provider;which is a default credentials provider chain. If no credentials are picked up that way, then we default to theconfigchain and try to find credentials in theProfileConfigFileAWSCredentialsProvider. The Aws sdk documentation says this is how it should work (although it is not implement that way)