-
Notifications
You must be signed in to change notification settings - Fork 998
Duck ai subscriber settings #6363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cmonfortep
merged 6 commits into
feature/cristian/subscriptions/show_duck_ai_pro_settings
from
feature/cristian/subscriptions/duck_ai_settings_paid
Jul 14, 2025
Merged
Duck ai subscriber settings #6363
cmonfortep
merged 6 commits into
feature/cristian/subscriptions/show_duck_ai_pro_settings
from
feature/cristian/subscriptions/duck_ai_settings_paid
Jul 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 9, 2025
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
19 tasks
184d41c
to
8bddd28
Compare
e43db88
to
a96c9d9
Compare
f21a2d9
to
ac3bffa
Compare
a96c9d9
to
2dfed6e
Compare
lmac012
approved these changes
Jul 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ac3bffa
to
030ec23
Compare
2dfed6e
to
b72818e
Compare
5ba29fc
into
feature/cristian/subscriptions/show_duck_ai_pro_settings
5 of 6 checks passed
cmonfortep
added a commit
that referenced
this pull request
Jul 14, 2025
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1210450968200755?focus=true ### Description Adds duck.ai subscriber settings ### Steps to test this PR _Feature 1_ - [x] Apply staging patch (any patch) - [x] Purchase a subscription - [x] In settings, subscription section, Duck.ai is listed - [x] Click on duck.ai - [x] Ensure you navigate to duck.ai setting screen - [x] Ensure pixel `m_privacy-pro_settings_paid-ai-chat_impression` sent - [x] click on learn more - [x] Ensure it navigates (url will fix later) - [x] go back - [x] Click on Open Duck.ai - [x] Ensure opens Duck.ai - [x] ensure pixel `m_privacy-pro_settings_paid-ai-chat_click` sent - [x] Go to settings and cancel your subscription - [x] Wait until expires - [x] When expired, ensure is listed in disabled state - [x] Clicking on the option does not open the screen ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
cmonfortep
added a commit
that referenced
this pull request
Jul 15, 2025
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1210450968200755?focus=true ### Description Adds duck.ai subscriber settings ### Steps to test this PR _Feature 1_ - [x] Apply staging patch (any patch) - [x] Purchase a subscription - [x] In settings, subscription section, Duck.ai is listed - [x] Click on duck.ai - [x] Ensure you navigate to duck.ai setting screen - [x] Ensure pixel `m_privacy-pro_settings_paid-ai-chat_impression` sent - [x] click on learn more - [x] Ensure it navigates (url will fix later) - [x] go back - [x] Click on Open Duck.ai - [x] Ensure opens Duck.ai - [x] ensure pixel `m_privacy-pro_settings_paid-ai-chat_click` sent - [x] Go to settings and cancel your subscription - [x] Wait until expires - [x] When expired, ensure is listed in disabled state - [x] Clicking on the option does not open the screen ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1210450968200755?focus=true
Description
Adds duck.ai subscriber settings
Steps to test this PR
Feature 1
m_privacy-pro_settings_paid-ai-chat_impression
sentm_privacy-pro_settings_paid-ai-chat_click
sentUI changes