Skip to content

Free Trial: Update Privacy Pro entry points in all locales #6370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2025

Conversation

nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Jul 10, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1201807753394693/task/1209708166734695?focus=true

Description

Add Free Trial copy to app Privacy Pro entry points if eligible and FF enabled

Steps to test this PR

Pre-steps

Onboarding

  • Fresh install
  • Go through onboarding
  • Check last context dialog (Privacy Pro) is showing Free Trial copy

Banner

  • Fresh install
  • Go to Settings > App Tracking Protection
  • Do AppTP onboarding
  • Check Privacy Pro banner shows free trial copy

Revoked

  • Enable AppTP
  • Enable an external VPN on your phone
  • Go back to AppTP screen
  • Check revoked banner shows free trial copy

Disabled

  • Disable AppTP
  • Enable an external VPN on your phone
  • Go back to AppTP screen
  • Check disabled banner shows free trial copy

Translations (Optional)

  • Switch your device language to something other than English
  • Check that all previous entry points have the Free Trial copy translated

FF disabled

  • Remove the second pre-step modification and set the feature flags to FALSE by default again
  • Check none of the previous entry points have the free trial copy

No UI changes

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag marked this pull request as ready for review July 10, 2025 16:24
Copy link
Contributor

@karlenDimla karlenDimla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nalcalag nalcalag force-pushed the feature/noelia/update_entry_points_with_free_trial branch from d4e7b9d to cb68007 Compare July 14, 2025 16:24
@nalcalag nalcalag merged commit 1a1270d into develop Jul 15, 2025
7 checks passed
@nalcalag nalcalag deleted the feature/noelia/update_entry_points_with_free_trial branch July 15, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants