Skip to content

The "char" type might be signed, both hash functions are defined to w… #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

The "char" type might be signed, both hash functions are defined to w… #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/BloomFilter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,16 +105,16 @@ bool BloomFilter::contains(const string &element) {

static unsigned int djb2Hash(const string &text) {
unsigned int hash = 5381;
for (const char &iterator : text) {
hash = ((hash << 5) + hash) + iterator;
for (auto ch : text) {
hash = ((hash << 5) + hash) + static_cast<unsigned char>(ch);
}
return hash;
}

static unsigned int sdbmHash(const string &text) {
unsigned int hash = 0;
for (const char &iterator : text) {
hash = iterator + ((hash << 6) + (hash << 16) - hash);
for (auto ch : text) {
hash = static_cast<unsigned char>(ch) + ((hash << 6) + (hash << 16) - hash);
}
return hash;
}
Expand Down Expand Up @@ -151,4 +151,4 @@ static vector<BlockType> readVectorFromStream(BinaryInputStream &in) {

size_t BloomFilter::getBitCount() const {
return bitCount;
}
}