Skip to content

Device enum support #1806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 11, 2025
Merged

Device enum support #1806

merged 18 commits into from
Jul 11, 2025

Conversation

jonathanKingston
Copy link
Contributor

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/72649045549333/task/1210512782751384?focus=true

Description

Adds a simple shim that talks to native if willPrompt if it will, we then use the presence of devices to shim the API.
If it won't prompt, we use the default API which shouldn't then cause issues.

Testing Steps

  • Go to example.com
  • Type navigator.mediaDevices.enumerateDevices() in the console
  • Check that the response works correctly.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

github-actions bot commented Jul 8, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@jonathanKingston jonathanKingston force-pushed the jkt/deviceEnumSupport branch from b563ac4 to d5abe30 Compare July 8, 2025 01:58
Copy link

github-actions bot commented Jul 8, 2025

[Beta] Generated file diff

Time updated: Fri, 11 Jul 2025 00:28:10 GMT

Android
    - android/contentScope.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScope.js

File has changed

Copy link

netlify bot commented Jul 8, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit b563ac4
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/686c7b02d7a60700083caa73
😎 Deploy Preview https://deploy-preview-1806--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 8, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit dec8f49
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68705a632137ca0008ce72ca
😎 Deploy Preview https://deploy-preview-1806--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jonathanKingston jonathanKingston force-pushed the jkt/deviceEnumSupport branch 3 times, most recently from f3a8f83 to a8675ef Compare July 8, 2025 16:02
@jonathanKingston jonathanKingston marked this pull request as ready for review July 10, 2025 23:46
@jonathanKingston jonathanKingston requested a review from a team as a code owner July 10, 2025 23:46
Copy link
Contributor

@dharb dharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Bizarre that this is necessary, but it is what it is.

@jonathanKingston
Copy link
Contributor Author

Bizarre that this is necessary, but it is what it is.

Totally lol!

@jonathanKingston jonathanKingston merged commit 342c5a5 into main Jul 11, 2025
16 checks passed
@jonathanKingston jonathanKingston deleted the jkt/deviceEnumSupport branch July 11, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants