-
Notifications
You must be signed in to change notification settings - Fork 29
NTP: Style Omnibar to match specs #1811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Fri, 11 Jul 2025 08:53:34 GMT Integration
File has changed Removed Files
❌ File only exists in old changeset Windows
File has changed Apple
File has changed |
shakyShane
requested changes
Jul 10, 2025
special-pages/pages/new-tab/app/omnibar/components/Container.js
Outdated
Show resolved
Hide resolved
205f9d0
to
c47d5aa
Compare
shakyShane
requested changes
Jul 11, 2025
special-pages/pages/new-tab/app/omnibar/components/SearchForm.js
Outdated
Show resolved
Hide resolved
special-pages/pages/new-tab/app/omnibar/integration-tests/omnibar.spec.js
Show resolved
Hide resolved
shakyShane
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209121419454298/task/1210610383905029
Description
Adjusts Omnibar styling to match the spec in https://www.figma.com/design/c3Y5zhEJhyu6HF6pz8lrMw/New-Tab-Page-Spec.
Haven’t quite reached perfection yet but I think best to get what I have merged behind the flag so that we can start getting feedback on this.
Done:
Still to do:
var()
.Testing Steps
https://deploy-preview-1811--content-scope-scripts.netlify.app/build/pages/new-tab/?omnibar=true
Checklist
Please tick all that apply: