Skip to content

NTP: Style Omnibar to match specs #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 11, 2025
Merged

NTP: Style Omnibar to match specs #1811

merged 19 commits into from
Jul 11, 2025

Conversation

noisysocks
Copy link
Contributor

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209121419454298/task/1210610383905029

Description

Adjusts Omnibar styling to match the spec in https://www.figma.com/design/c3Y5zhEJhyu6HF6pz8lrMw/New-Tab-Page-Spec.

Haven’t quite reached perfection yet but I think best to get what I have merged behind the flag so that we can start getting feedback on this.

Done:

  • Styling for the logo, tab switcher, search form, suggestions list, and AI form.
  • Light and dark mode.
  • Animations for the tab switcher and input container.

Still to do:

  • Add Windows styling.
  • Check typography – I think there’s a few differences compared to the spec.
  • Clean up CSS variables – there might be more dimensions and colours that can be replaced with a var().
  • Clean up SVG icons – there might be some we’re no longer using.
  • Finesse the animations – I can see a few little things that are off, like the Search icon popping in.

Testing Steps

https://deploy-preview-1811--content-scope-scripts.netlify.app/build/pages/new-tab/?omnibar=true

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@noisysocks noisysocks requested review from shakyShane, mgurgel and a team as code owners July 10, 2025 06:38
@noisysocks noisysocks added the enhancement New feature or request label Jul 10, 2025
Copy link

netlify bot commented Jul 10, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 5fa82ea
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/6870d0d7611dc70008273449
😎 Deploy Preview https://deploy-preview-1811--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Jul 10, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jul 10, 2025

[Beta] Generated file diff

Time updated: Fri, 11 Jul 2025 08:53:34 GMT

Integration
    - integration/pages/history/dist/index.js
  • integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js
  • integration/pages/new-tab/locales/en/new-tab.json

File has changed

Removed Files
    - integration/pages/new-tab/icons/Logo-Stacked.svg
  • windows/pages/new-tab/icons/Logo-Stacked.svg
  • dist/pages/new-tab/icons/Logo-Stacked.svg

❌ File only exists in old changeset

Windows
    - windows/pages/history/dist/index.js
  • windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js
  • windows/pages/new-tab/locales/en/new-tab.json

File has changed

Apple
    - dist/pages/history/dist/index.js
  • dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js
  • dist/pages/new-tab/locales/en/new-tab.json

File has changed

cursor[bot]

This comment was marked as outdated.

@noisysocks noisysocks changed the title Randerson/omnibar styling NTP: Style omnibar to match specs Jul 10, 2025
@noisysocks noisysocks changed the title NTP: Style omnibar to match specs NTP: Style Omnibar to match specs Jul 10, 2025
@noisysocks noisysocks force-pushed the randerson/omnibar-styling branch from 205f9d0 to c47d5aa Compare July 11, 2025 00:33
cursor[bot]

This comment was marked as outdated.

@noisysocks noisysocks requested a review from shakyShane July 11, 2025 01:41
@noisysocks noisysocks requested a review from shakyShane July 11, 2025 08:40
cursor[bot]

This comment was marked as outdated.

@noisysocks noisysocks merged commit f1a3a75 into main Jul 11, 2025
16 checks passed
@noisysocks noisysocks deleted the randerson/omnibar-styling branch July 11, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants