Skip to content

Use tag instead of hash to fix updating #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Jul 10, 2025

Asana Task/Github Issue: duckduckgo/privacy-configuration#3436

Description

Ensure we use the tag version of the config.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Jul 10, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 16900f8
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68778133150ef20008da00e6
😎 Deploy Preview https://deploy-preview-1816--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Jul 10, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jul 10, 2025

[Beta] Generated file diff

Time updated: Wed, 16 Jul 2025 10:39:44 GMT

@jonathanKingston jonathanKingston marked this pull request as ready for review July 10, 2025 15:33
@jonathanKingston jonathanKingston requested a review from a team as a code owner July 10, 2025 15:33
cursor[bot]

This comment was marked as outdated.

shakyShane
shakyShane previously approved these changes Jul 11, 2025
cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Test Incorrectly Reads Project Dependencies

The dependency-format.spec.js test incorrectly attempts to read project-level dependencies from injected/package.json using ../package.json. It should instead target the root package.json with ../../package.json.

injected/unit-test/dependency-format.spec.js#L8-L9

const __dirname = path.dirname(__filename);
const pkg = JSON.parse(fs.readFileSync(path.join(__dirname, '../package.json'), 'utf-8'));

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants