-
Notifications
You must be signed in to change notification settings - Fork 227
Clean Code for bundles/org.eclipse.jface.text #3293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Clean Code for bundles/org.eclipse.jface.text #3293
Conversation
41d9bee
to
03683f1
Compare
...clipse.jface.text/src/org/eclipse/jface/text/contentassist/AsyncCompletionProposalPopup.java
Outdated
Show resolved
Hide resolved
03683f1
to
ab6b8d6
Compare
@laeubi This is simply non reviewable (even according to Github UI). Is there a way to run smaller set of changes for this bundle or should it be done manually so we got a PR that can actually be reviewed? |
ab6b8d6
to
88bee99
Compare
88bee99
to
d1391ba
Compare
...clipse.jface.text/src/org/eclipse/jface/text/contentassist/AsyncCompletionProposalPopup.java
Outdated
Show resolved
Hide resolved
7ea3aa8
to
3bf0879
Compare
@akurtakov I think most of these changes are "Convert control statement bodies to block". I run this clean-up manually and push it in smaller batches so that this becomes reviewable. |
2b521f0
to
3373e3f
Compare
3373e3f
to
2daca21
Compare
2daca21
to
1defe6a
Compare
5a9b96f
to
2c6a902
Compare
Ups, sorry, clicked the default (merge) instead of the rebase. I can update this later tonight and remove the merge commit. @akurtakov is it possible to disable the "Update with merge" option from the webui? |
No idea . |
47441f5
to
153addf
Compare
Has been updated by the bot |
153addf
to
4f86007
Compare
6b3e8b1
to
6f0acd8
Compare
6f0acd8
to
f9afe16
Compare
The following cleanups were applied: