Migrate JUnit 4 tests to JUnit 5 in org.eclipse.text.tests #3411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 2 751 files - 267 2 751 suites - 267 2h 12m 3s ⏱️ - 22m 59s For more details on these failures and errors, see this check. Results for commit 449ef4a. ± Comparison against base commit 8ff6a17. This pull request removes 649 tests.♻️ This comment has been updated with latest results. |
vogella
force-pushed
the
jface.text.tests_3
branch
from
efe351b to
9e47852
Compare
This commit fixes JUnit 4 to JUnit 5 migration issues in the test bundle: Changes: - Fixed all JUnit import statements (org.junit.Assert -> org.junit.jupiter.api.Assertions) - Fixed assertion parameter order for simple cases (message parameter moved to last position) - Fixed 16 test files with straightforward assertion patterns Files modified: - ProjectionDocumentTest.java (partial) - ProjectionMappingTest.java - AbstractGapTextTest.java - AbstractLineTrackerTest.java - ChildDocumentTest.java - DocumentTest.java - ExclusivePositionUpdaterTest.java - FindReplaceDocumentAdapterTest.java - LineTrackerTest3.java (partial) - LineTrackerTest4.java (partial) - MultiStringMatcherTest.java - PositionUpdatingCornerCasesTest.java - TextEditTests.java - TextStoreTest.java (partial) - TextUtilitiesTest.java - InclusivePositionUpdaterTest.java Remaining work: - 71 compilation errors remain in files with complex assertion patterns - These involve string concatenation with method calls (e.g., "msg: " + i, val, obj.method()) - Will require manual fixes or IDE refactoring tools 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
This commit fixes compilation errors from the JUnit 5 migration by correcting
the assertion parameter order across multiple test files. In JUnit 5, the
message parameter must be last, not first.
Changes:
- Fixed assertEquals/assertTrue/assertNull/assertNotNull parameter order
where message parameter was incorrectly placed first instead of last
- Updated 9 test files with assertion fixes:
- AbstractGapTextTest.java: Fixed assertTrue parameter order
- AbstractLineTrackerTest.java: Fixed assertEquals parameter order
- ChildDocumentTest.java: Fixed assertEquals parameter order in multiple methods
- LineTrackerTest3.java: Fixed assertEquals parameter order (multiple occurrences)
- LineTrackerTest4.java: Fixed assertTrue parameter order
- MultiStringMatcherTest.java: Fixed assertEquals, assertNull, and assertNotNull
parameter order across multiple test methods
- PositionUpdatingCornerCasesTest.java: Fixed assertEquals parameter order
- TextEditTests.java: Fixed assertEquals parameter order in multiple methods
- TextStoreTest.java: Fixed assertEquals parameter order (multiple occurrences)
JUnit 4 format (old): assertEquals("message", expected, actual)
JUnit 5 format (new): assertEquals(expected, actual, "message")
All tests now compile successfully with 0 errors.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.