Notification when a Thing is down monitering #65

sailalithkanumuri8 · 2025-06-18T04:24:04Z

I have added a monitoring folder with the code to detect if a thing is down or if it is up and running. If a thing is down, it will send a notification to the email specified in the .env file in the thing-moniter folder. This may need more additional testing: I have tested if all things are up and whether an email is sent if a thing is down. To run my test, type "node test-moniter.js" in the terminal in the root directory.

…numuri8/test-things into sai-notifications-monitering

danielpeintner · 2025-06-18T07:25:46Z

Very quick high level comment. The macOS files like .DS_Store should not be part of the PR.
I think it makes sense to add them to .gitignore

egekorkan

I am sorry but this PR is way too much and feels like AI-generated. You are adding way too many unnecessary things and also code that is not used (e.g. adding node-wot dependency but not using it). Please reconsider how you approach adding features

egekorkan · 2025-06-20T11:59:42Z

.env

+SMTP_HOST=sandbox.smtp.mailtrap.io
+SMTP_PORT=2525
+SMTP_USER=47aa65a98dd245
+SMTP_PASS=b553f1f0235cde
+NOTIFICATION_EMAIL=[email protected]


such information should never be committed to git

Sorry I didn't mean to commit this, I wanted to put it in the .gitignore but I forgot

egekorkan · 2025-06-20T11:59:55Z

docker-compose-things.yml

@@ -256,6 +256,18 @@ services:
          memory: 25M
    networks:
      - things_network
+  mqtt-broker:


not sure why an mqtt broker is added

Because I used the broker in the code to do the manual health check, I had to include it. I will remove it though

egekorkan · 2025-06-20T12:00:18Z

monitoring/thing-monitor/.env

this is just duplicating the whole .env file . Why?

I did that so that I can put it in the .gitignore file as it as the mailtrap credentials, sorry forgot to do that

egekorkan · 2025-06-20T12:02:24Z

monitoring/thing-monitor/src/monitor.ts

+
+    private async checkMqttThing(thing: ThingConfig, currentStatus: ThingStatus): Promise<void> {
+        return new Promise((resolve, reject) => {
+            const client = mqtt.connect(`mqtt://${thing.host}:${thing.port}`, {


Suggested change

const client = mqtt.connect(`mqtt://${thing.host}:${thing.port}`, {

const client = mqtt.connect(`mqtt://${thing.host}:${thing.port}`, {

thing.host should not exist? I am not sure why you are doing this if you are including the mqtt binding of node-wot anyways

Ok I have removed the code for the mqtt health check and now I am fully relying on node-wot for this

egekorkan · 2025-06-20T12:02:58Z

monitoring/thing-monitor/src/monitor.ts

+        // For now, we'll do a simple UDP socket connection to the port
+        const dgram = await import('dgram');
+        return new Promise((resolve, reject) => {
+            const client = dgram.createSocket('udp4');


please don't write such low level code. you have node wot coap binding anyways?

You are right. I will fix this

egekorkan · 2025-06-20T12:05:15Z

monitoring/thing-monitor/src/test.ts

+// NOTE: The health check now verifies the Thing Description is available over HTTP.
+// Ensure your test Things have a TD available at the specified host/port.
+const testConfig: MonitorConfig = {
+    heartbeatInterval: 5000, // 5 seconds for testing


this should be configurable

pretty much all this kind of parameters

Sure, I didn't do it because it is a test file but that works as well

egekorkan · 2025-06-20T12:06:22Z

monitoring/thing-monitor/src/monitor.ts

+
+        // Start the WoT servient ONCE. This is a critical change.
+        try {
+            await this.servient.start();


are you using the servient at all?

Fixed, I just realized this

egekorkan · 2025-06-20T12:06:57Z

monitoring/thing-monitor/src/test.ts

+
+        // Let it run for a while to test notifications
+        console.log('\nMonitoring for 20 seconds...');
+        await new Promise(resolve => setTimeout(resolve, 20000));


this should be configurable

egekorkan · 2025-06-20T12:07:14Z

mosquitto/config/mosquitto.conf

why is this added?

It was part of the mqtt broker code I included before. Deleted it now

egekorkan · 2025-06-20T12:07:50Z

test-monitor.js

+    {
+        name: 'http-express-calculator-simple',
+        protocol: 'http',
+        host: 'localhost',


in the deployment, they are not localhost. This should be configurable

Ok fixed this

sailalithkanumuri8 · 2025-06-23T23:20:44Z

Ok hopefully I have implemented all your feedback. I have looked throughly on all the changes. I have used servient and node-wot throughout the entire monitoring code structure and removed all the mqtt code. Please let me know if there are any other changes I should make

danielpeintner · 2025-06-24T07:03:00Z

mosquitto/log/mosquitto.log is probably not needed. mosquitto/log/mosquitto.db I don't think either.
It is the about the data that gets generated, right?

sailalithkanumuri8 · 2025-06-24T16:13:35Z

Yeah I don't think that is needed anymore. I will delete it. To fix the ECA issue, I will make a new PR if that is fine with you.

sailalithkanumuri and others added 4 commits June 14, 2025 16:47

Added monitoring notifications

28b43d2

Update .env

46adc01

Fixed monitering

de2b57b

Merge branch 'sai-notifications-monitering' of github.com:sailalithka…

1eef941

…numuri8/test-things into sai-notifications-monitering

egekorkan requested changes Jun 20, 2025

View reviewed changes

sailalithkanumuri8 added 2 commits June 23, 2025 16:17

Implemented feedback

54f07c1

Updated .env file

ef6bd87

Added more clarity with comments on what is going on

3121420

sailalithkanumuri8 closed this Jun 24, 2025

	const client = mqtt.connect(`mqtt://${thing.host}:${thing.port}`, {
	const client = mqtt.connect(`mqtt://${thing.host}:${thing.port}`, {

Notification when a Thing is down monitering #65

Notification when a Thing is down monitering #65

Uh oh!

Conversation

sailalithkanumuri8 commented Jun 18, 2025

Uh oh!

danielpeintner commented Jun 18, 2025

Uh oh!

egekorkan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sailalithkanumuri8 commented Jun 23, 2025

Uh oh!

danielpeintner commented Jun 24, 2025

Uh oh!

sailalithkanumuri8 commented Jun 24, 2025

Uh oh!

Uh oh!