Skip to content

Dockerized Counter thing #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sailalithkanumuri8
Copy link

I have dockerized the counter thing in the test-things repo, which was previously supposed to be in the node-wot repo. Please let me know if there is any changes I should make.

@danielpeintner
Copy link
Member

Some meta comments (not about the actual content, rather in general)

@egekorkan
Copy link
Member

@sailalithkanumuri8 some issues:

  • Monitoring should be another PR
  • You have two GitHub users: Please choose one and stick to it
  • ECA issue should be solved. Some options:
    • Fresh commits
    • Squash all the commits and sign the last one
    • Undo your commits and recommit when signed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a TD as it doesnt have href in the forms. You should commit the TM (that looks like this) and the TD assuming it is hosted under plugfest.thingweb.io

});
};

const thingDescription = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once you have the TM as a file, it should be used to read here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MQTT broker should not be here but the counter thing should be added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants