chore: BOMS-39 rename arbi-bom to orbi-bom #357
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR renames references from "arbi-bom" to "orbi-bom" as part of a chore task (BOMS-39). The change includes adding a success notification step to the Python requirements upgrade workflow.
- Updates email recipient from arbi-bom to orbi-bom for consistency
- Adds new success notification step to notify when the workflow completes successfully
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
vgulati-apphelix
force-pushed
the
vgulati/boms-39_rename
branch
from
3b7ea23 to
5128eef
Compare
robrap
reviewed
Oct 14, 2025
| subject: Upgrade python requirements workflow executed successfully in ${{github.repository}} | ||
| to: '[email protected]' | ||
| from: github-actions <[email protected]> | ||
| body: Upgrade python requirements workflow executed in ${{ github.repository }}. For details see "github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}" |
There was a problem hiding this comment.
I know this was probably copy/pasted from elsewhere, but thought we could make the status more clear in the body as well.
Suggested change
| body: Upgrade python requirements workflow executed in ${{ github.repository }}. For details see "github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}" | |
| body: Upgrade python requirements workflow successfully executed in ${{ github.repository }}. For details see "github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}" |
Comment on lines
+79
to
+80
| username: ${{secrets.edx_smtp_username}} | ||
| password: ${{secrets.edx_smtp_password}} |
There was a problem hiding this comment.
Should we use consistent CAPS with the failure code?
There was a problem hiding this comment.
Note: The other PR has all caps for some secrets, but not these, and maybe they should all move to ALL-CAPS?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames references from "arbi-bom" to "orbi-bom" as part of a chore task (BOMS-39). The change includes adding a success notification step to the Python requirements upgrade workflow.