Add tcp servers and clients to standard library #1058
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a memory leak and increases the backlog of uv_listen to SOMAXCONN, such that connections are put in a queue when the previous acceptor is not yet finished (this is the case with a timeout, which triggers the connects at the same time) Another memory leak remains which I couldn't find. ``` ==130847== 128 bytes in 1 blocks are definitely lost in loss record 1 of 1 ==130847== at 0x48577A8: malloc (vg_replace_malloc.c:446) ==130847== by 0x4003F90: ??? (in server_client) ==130847== by 0x4004499: ??? (in server_client) ==130847== by 0x4004557: run (in server_client) ==130847== by 0x4004A1C: spawn_4055 (in server_client) ==130847== by 0x40044F6: resume_Int (in server_client) ==130847== by 0x4002BA0: c_tcp_listen (io.c:367) ==130847== by 0x4004B65: listen_4331 (in server_client) ==130847== by 0x400CA5D: effektMain (in server_client) ==130847== by 0x4003D60: main (main.c:37) ```
|
Perhaps the other leak is the same as this one: libuv/libuv#559 |
|
Looks indeed similar, I believe the 128 byte object to be some internal UV structure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server_clientand more than 2 clients