Skip to content

[Fix/client/waitingroom-UI] 대기실 오류 및 게임 시작 수정 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 1, 2024
Merged

[Fix/client/waitingroom-UI] 대기실 오류 및 게임 시작 수정 #26

merged 7 commits into from
Dec 1, 2024

Conversation

zziglet
Copy link
Collaborator

@zziglet zziglet commented Dec 1, 2024 •
edited
Loading

🐣Title

[Fix/client/waitingroom-UI] 대기실 오류 및 게임 시작 수정


🐣Part

client


🐣Key Changes

  1. 대기실 입퇴장 오류 수정
  2. 새로고침 오류 수정
  3. 게임 룸 입장 수정

🐣Simulation

2024-12-02.12.35.21.mov

🐣To Reviewer

  1. 클라이언트 스레드 자체가 실행 중일 때는 유효하게 작동합니다
  2. 사용자가 스윙 윈도우 창 자체를 종료했을 때의 예외처리를 게임 전체적으로 해야할 것 같습니다. @solved2
  3. 게임 룸으로 이동할 때 레이아웃이 바뀌는 것 같아서 맵이랑 맞춰야 할 것 같습니다.
  4. 게임 시작 시 도망자의 경우 플레이어가 그려지지 않는 오류가 있습니다. 게임 맵에서 도망자 그림이 설정되지 않은 것 같아요!..

🐣Next

게임 결과 화면 출력


🐣Issue

@zziglet zziglet requested a review from zero2vec December 1, 2024 11:51
@ekgns33 ekgns33 added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 1, 2024
@ekgns33 ekgns33 added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 1, 2024
@ekgns33 ekgns33 added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 1, 2024
@ekgns33 ekgns33 added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 1, 2024
@zziglet zziglet marked this pull request as ready for review December 1, 2024 15:25
@zziglet zziglet changed the title [WIP] [Fix/client/waitingroom-UI] 대기실 오류 및 게임 시작 수정 [Fix/client/waitingroom-UI] 대기실 오류 및 게임 시작 수정 Dec 1, 2024
@zero2vec zero2vec merged commit 608d983 into main Dec 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zero2vec zero2vec Awaiting requested review from zero2vec

Assignees
No one assigned
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zziglet @ekgns33 @zero2vec