Remove Uri sources from navigation rendering. #1546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the need to keep track of NavigationSource on markdown files to render the navigation. Previous to this we needed the keep this around to track the 'real' parent of a section once it may have been reshuffled by `navigation.yml`. We now more diligently build the global navigation more truthfully and can relay on walking the current navigation items `.Parent` to find the proper root to render. This includes scrubbing/skipping phantoms from the navigation. Another step to refactoring our navigation acyclic graph as the single source of truth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the need to keep track of NavigationSource on markdown files to render the navigation.
Previous to this we needed the keep this around to track the 'real' parent of a section once it may have been reshuffled by
navigation.yml.We now more diligently build the global navigation more truthfully and can rely on walking the current navigation items
.Parentto find the proper root to render.This includes scrubbing/skipping phantoms from the navigation.
In particular this makes src/tooling/docs-assembler/Navigation/GlobalNavigationHtmlWriter.cs a whole lot simpler.
Another step to refactoring our navigation acyclic graph as the single source of truth.
cursorful-video-1752141645394.mp4