Skip to content

Add support for httpx authentication class #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for httpx authentication class #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions elastic_transport/_node/_http_httpx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,22 @@ def __init__(self, config: NodeConfig):
elif config.client_cert:
ssl_context.load_cert_chain(config.client_cert)

# Httpx supports setting 'auth' via _extras['requests.session.auth'] = ...
# The naming is weird but it enables compatibility with the existing
# 'requests.session.auth' parameter
try:
httpx_auth: Optional[httpx.Auth] = config._extras.pop(
"requests.session.auth", None
)
except AttributeError:
httpx_auth = None

self.client = httpx.AsyncClient(
base_url=f"{config.scheme}://{config.host}:{config.port}",
limits=httpx.Limits(max_connections=config.connections_per_node),
verify=ssl_context or False,
timeout=config.request_timeout,
auth=httpx_auth,
)

async def perform_request( # type: ignore[override]
Expand Down
Loading