-
Notifications
You must be signed in to change notification settings - Fork 103
Adds cat node -h values #4771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adds cat node -h values #4771
Conversation
Following you can find the validation changes for the API you have modified.
You can validate this API yourself by using the |
* * `MANUAL_ALLOCATION`: The shard’s allocation was last modified by the Cluster reroute API. | ||
* * `NEW_INDEX_RESTORED`: Unassigned as a result of restoring into a new index. | ||
* * `NODE_LEFT`: Unassigned as a result of the node hosting it leaving the cluster. | ||
* * `NODE_RESTARTING`: Similar to NODE_LEFT, except that the node was registered as restarting using the Node shutdown API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* * `NODE_RESTARTING`: Similar to NODE_LEFT, except that the node was registered as restarting using the Node shutdown API. | |
* * `NODE_RESTARTING`: Similar to `NODE_LEFT`, except that the node was registered as restarting using the Node shutdown API. |
/** @non_exhaustive */ | ||
export enum CatShardColumn { | ||
/** | ||
* The size of completion. For example: `0b`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The size of completion. For example:
0b
.
Not a big deal but I noticed this one starts with "The" and the rest don't. IMO they ought to be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two minor comments, otherwise output LGTM!
This PR adds the enumerated values for the -h parameter in the following APIs:
Related issue: #4345