Skip to content

[Backport 9.1] Add index block removal API #4780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

[Backport 9.1] Add index block removal API #4780

merged 1 commit into from
Jul 4, 2025
+802 −92

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 4, 2025

Backport e668a98 from #4684.

@nielsbauman @pquentin @github-actions
Add index block removal API (#4684)
5da20c1 
* Add index block removal API

Follow-up of elastic/elasticsearch#129128

* Fix block enum

* Add doc-id to table

* Fix lint

* Move IndicesBlockOptions and IndicesBlockStatus to indices/_types

It's breaking but avoids duplicating the type names, which is forbidden.

* Separate BlockStatus as it is different

* Rename response example file

* Fix response fields

* Add index privilege

---------

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit e668a98)
@pquentin pquentin closed this Jul 4, 2025
@pquentin pquentin reopened this Jul 4, 2025
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Jul 4, 2025

Following you can find the validation changes for the APIs you have modified.

API Status Request Response
indices.create 🔴 1291/1328 → 1269/1310 1328/1328 → 1310/1310
indices.create_data_stream 🟢 117/117 → 116/116 117/117 → 116/116
indices.flush 🟢 50/50 → 49/49 50/50 → 49/49
indices.forcemerge 🟢 14/14 → 13/13 14/14 → 13/13
indices.get_data_stream 🔴 117/117 → 115/115 17/117 → 71/115
indices.get_field_mapping 🟢 26/26 → 18/18 26/26 → 18/18
indices.get_mapping 🔴 211/211 → 202/202 201/211 → 192/202
indices.put_index_template 🔴 125/148 → 124/147 148/148 → 147/147
indices.put_mapping 🔴 140/143 → 138/143 146/146
indices.refresh 🟢 306/306 → 301/301 306/306 → 301/301
indices.remove_block 🟠 → 🟢 Missing type → 1/1 Missing type → 1/1
indices.rollover 🔴 53/53 → 52/52 2/53 → 2/52

You can validate these APIs yourself by using the make validate target.

pquentin
pquentin approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validation diff is confused, it looks it uses main recordings.

@pquentin pquentin merged commit 0217fff into 9.1 Jul 4, 2025
8 checks passed
@pquentin pquentin deleted the backport-4684-to-9.1 branch July 4, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pquentin @nielsbauman