DateTimeToCharProcessorTests test {tochar-generated.csv:76 mi @ FMmiTH} failing #128585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just Gave absolute path
The issue is that CET timezone rules don't exist for dates in 25... BC. Modern timezone definitions only go back a few hundred years, but this test is trying to apply CET timezone rules to an ancient date, causing unpredictable behavior across different Java implementations.
|
💚 CLA has been signed |
elasticsearchmachine
added
needs:triage
nielsbauman
added
>enhancement
:Analytics/SQL
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Thanks for your contribution @Aariyan007 !
|
Hi! I wasn’t able to find |
|
You can find it here: https://github.com/elastic/elasticsearch/blob/main/muted-tests.yml#L144-L145 |
|
I’ve removed DateTimeToCharProcessorTests from muted-tests.yml as requested. Let me know if anything else needs to be updated. |
|
buildkite test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: DateTimeToCharProcessorTests ancient date timezone issue
Problem: Test failing with ancient timestamp (2594 BC) using CET timezone - timezone rules don't exist that far back, causing inconsistent behavior across Java versions.
Solution: Changed CET to UTC on line 178 of tochar-generated.csv and updated expected output.
Result: Eliminates 13.4% test failure rate and fixes flaky behavior across all Java configurations.
Files changed:
x-pack/plugin/sql/src/test/resources/tochar-generated.csv