Use ILM skip setting in shrink action #129455
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add the skip setting to prevent ILM from processing the shrunken index before the execution state has been copied - which could happen if the shards of the shrunken index take a long time to allocate. Resolves elastic#109206
nielsbauman
added
>bug
:Data Management/ILM+SLM
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
Team:Data Management
|
Hi @nielsbauman, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the ILM skip setting within the shrink action to avoid premature ILM processing prior to copying the execution state. It updates both test and production code in ShrinkStep and CopyExecutionStateStep, and documents the change in the changelog.
- Adds the skip setting to the ILM shrink action in both the production code and tests.
- Removes the skip setting from the index settings in CopyExecutionStateStep after copying the execution state.
- Updates the changelog to reflect the behavioral change.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/ShrinkStepTests.java | Adds a test for the new ILM skip setting. |
| x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/ShrinkStep.java | Adds the ILM skip setting to the shrink action. |
| x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/CopyExecutionStateStep.java | Removes the skip setting post execution state copy to allow proper ILM re-processing. |
| docs/changelog/129455.yaml | Documents the resolution of #109206 with the ILM skip setting behavior. |
Comments suppressed due to low confidence (1)
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/CopyExecutionStateStep.java:117
- Consider calling newSettings.build() to convert the Settings.Builder to a Settings instance if indexMetadataBuilder.settings() expects an immutable Settings object.
indexMetadataBuilder.settings(newSettings);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add the skip setting to prevent ILM from processing the shrunken index before the execution state has been copied - which could happen if the shards of the shrunken index take a long time to allocate.
Resolves #109206