Don't use ThrottledTaskRunner for async cache evictions #129458
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvement to asynchronous shared blob cache evictions
In testing the deletion of 2,000 searchable snapshots, the time taken for the cluster state update was
The pre-optimised version would increase exponentially with the amount deleted, whereas the difference between the status quo and this change would be linear. It also looks like the JIT kicked in by the time the third node did the evictions and then all implementations went down to ~200 -> 220ms. So I guess the. danger is the first time this happens on a node that hasn't JIT-ted the cache eviction codepath?
Not sure if it's worth the additional complexity.