Skip to content

Add more test coverage for nested searches over flat vector indices #130263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

benwtrent
Copy link
Member

PR #130251 made me realize we were missing some important coverage.

This adds nested vector query (and top level knn) tests for flat indices in our yaml tests.

@benwtrent benwtrent added >test Issues or PRs that are addressing/adding tests :Search Relevance/Vectors Vector search v9.2.0 labels Jun 27, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jun 27, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benwtrent benwtrent added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jun 30, 2025
Copy link
Contributor

@john-wagster john-wagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elasticsearchmachine elasticsearchmachine merged commit 50c2cd3 into elastic:main Jun 30, 2025
32 checks passed
@benwtrent benwtrent deleted the test/nested-flatten-vector branch June 30, 2025 15:02
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 3, 2025
…lastic#130263)

PR elastic#130251 made me realize
we were missing some important coverage.

This adds nested vector query (and top level knn) tests for flat indices
in our yaml tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants