[Visual Refresh] Shadow tokens #8880
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on spec https://www.figma.com/design/FHys7gLzyvD1gc9DrJM6D8/Elastic-UI--Borealis-?node-id=8222-4311&t=0YSfDbFLOkB0xZmj-0 Amsterdam values will be added later
in helper function that will probably get removed, but well
acstll
added
skip-changelog
This was referenced Jul 17, 2025
this was not returning a value according to the new spec
Amsterdam stays as is
via modify prop in EuiThemeProvider
💚 Build SucceededHistory
cc @acstll |
💚 Build Succeeded
History
cc @acstll |
|
There is an issue with dark mode in I'm working on removing this extra border for dark mode but it's not straightforward because of the many moving parts (Borealis/Amsterdam, accessibility, color mode, shadow/border props). Toggle screenshot
Edit: solving the double-border-in-dark-mode issue is not straightforward. I'm putting that on hold until we understand the problem better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements https://github.com/elastic/eui-private/issues/195
Important
This PR targets a feature branch!
Docs draft: https://eui.elastic.co/pr_8880/docs/getting-started/theming/tokens/shadows/
Changes
flattoken to keepeuiShadowFlatunchangedflatfalls back toxstokens as SCSSand update SCSS mixins 25ed168euiSlightShadowHovereuiShadowFlatEuiShadowOptions.colorEuiShadowCustomColorAdded unit test toensure overrides in theme.modify work as expected c3b2896Why are we making this change?
This is part of the Visual Refresh project.
Screenshots
N/A
Impact to users
No impact for users. The visual aspect of shadows is slightly different.
QA
Remove or strikethrough items that do not apply to your PR.
General checklist
Checked in both MacOS and Windows high contrast modes(emulate forced colors if you do not have access to a Windows machine.)Checked in mobileChecked for accessibility including keyboard-only and screenreader modes@defaultif default values are missing) and playground togglesChecked Code Sandbox works for any docs examplesA changelog entry exists and is marked appropriately.If applicable, added the breaking change issue label (and filled out the breaking change checklist)If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)