-
Notifications
You must be signed in to change notification settings - Fork 176
[apm]: Document sampling.tail.discard_on_write_failure config #4908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[apm]: Document sampling.tail.discard_on_write_failure config #4908
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
[For reviewers] Note sure which Follow Up Tasks option to select and I am not sure if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one tiny suggestion to match the docs-content
PR, but otherwise LGTM
…Write Failure config
956d463
to
13637d4
Compare
Removing backport-8.19 label because the PR is already targeting 8.x (8.19) |
Co-authored-by: Carson Ip <[email protected]>
This pull request is now in conflict. Could you fix it @isaacaflores2? 🙏
|
# Conflicts: # docs/en/observability/apm/configure/sampling.asciidoc
Description
Adding description for new config that will be available on v8.19+. The description matches the one provided in the v9.1.0 docs: elastic/docs-content#1453
Documentation sets edited in this PR
Check all that apply.
docs/en/observability/*
)docs/en/serverless/*
)docs/en/integrations/*
)Related issue
Closes elastic/apm-server#15330
Checklist
Follow-up tasks
Select one.
Testing
I kept getting the below error building the docs locally when running
../docs/build_docs --doc docs/en/observability/apm/configure/sampling.asciidoc --resource ../apm-server --resource ../ingest-docs/docs --open
I validated with asciidoc plugin instead: