-
Notifications
You must be signed in to change notification settings - Fork 731
chore: update electron-quick-start references #1714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tests/mocks/npm-response-main.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These mocks are unused to my knowledge
src/main/content.ts
Outdated
@@ -13,7 +13,7 @@ import { IpcEvents } from '../ipc-events'; | |||
// parent directory of all the downloaded template fiddles | |||
const TEMPLATES_DIR = path.join(app.getPath('userData'), 'Templates'); | |||
|
|||
// location of the fallback template fiddle used iff downloading failed | |||
// location of the fallback template fiddle used if downloading failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was intentional (iff = if and only if)
@yangannyx, I think this PR might be missing a commit? I don't see any actual changes to the |
@yangannyx, Is this PR still ongoing? If it is, it might be better to mark it as a Draft. |
Hey @dsanders11 , @BlackHole1 apologies for the late reply. This PR is complete, it removes the |
This PR updates references to
electron-quick-start
to the renamed repominimal-repro
.Fiddle currently uses
electron-quick-start
in the folder names of its template caching logic. I decided not to change this logic since it's internal to how fiddle operates and not something general electron consumers will be exposed to