Skip to content

Introduce configurable auto leave option #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: livekit
Choose a base branch
from

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Jun 27, 2025

If the call widget is started with the URL parameter: telephoneAutoLeave we want the call to automatically hangup when the other participants leaves. This PR implements this behavior.

@toger5 toger5 force-pushed the toger5/auto-leave-when-others-left branch from 826db44 to d4bca13 Compare June 27, 2025 14:02
@toger5 toger5 changed the title Introduce condigurable auto leave option Introduce configurable auto leave option Jun 30, 2025
@toger5 toger5 force-pushed the toger5/auto-leave-when-others-left branch from d4bca13 to 81864fe Compare June 30, 2025 10:33
@toger5 toger5 marked this pull request as ready for review June 30, 2025 12:50
@toger5 toger5 requested a review from a team as a code owner June 30, 2025 12:50
@toger5 toger5 requested a review from BillCarsonFr June 30, 2025 12:50
@toger5 toger5 marked this pull request as draft June 30, 2025 12:50
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would have been easier to review if there was not a mix of refactoring to add an option object to the view model and mode the encryptionSystem in it as well as adding the new param.

This feature doesn't seem trivial for me and I see zero test to check what it is doing.
It looks to me that this as the potential to auto hangup on you, and I expect some test for the happy path as well as the edge cases. Maybe it will auto hangup on join at this point..

@toger5
Copy link
Contributor Author

toger5 commented Jun 30, 2025

I put it out of review and back into draft since I also wanted the tests.

@BillCarsonFr
Copy link
Member

I put it out of review and back into draft since I also wanted the tests.

👍 I followed a notification to review it. Good luck with the testing.

BTW is it compatible with the Lobby? or it will only work when no lobby (asking because of the telephone prefix in the option name)

@toger5
Copy link
Contributor Author

toger5 commented Jun 30, 2025

BTW is it compatible with the Lobby? or it will only work when no lobby (asking because of the telephone prefix in the option name)

It will only happen in the call. Since we only have a running call view model once we join a call.

I am not sure the telephone prefix makes sense however

@toger5
Copy link
Contributor Author

toger5 commented Jul 1, 2025

This would be nice to be built on top of the UrlParam refactor pr but its still open to review since it does not really make a difference if we update this one with the changes of the refactor or if we update the rafactor to include the new params introduced here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants