Add experimental and incomplete support for MSC4306: Thread Subscriptions. #18674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reivilibre
changed the title
reivilibre
commented
Jul 10, 2025
reivilibre
force-pushed
the
rei/threads2_sub
branch
from
3f39f20 to
29d4fc3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
reivilibre
force-pushed
the
rei/threads2_sub
branch
3 times, most recently
from
82fc0d9 to
07bbbcf
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
reivilibre
force-pushed
the
rei/threads2_sub
branch
4 times, most recently
from
fe2541b to
79ecd7c
Compare
Signed-off-by: Olivier 'reivilibre <[email protected]>
reivilibre
force-pushed
the
rei/threads2_sub
branch
from
79ecd7c to
fdd1d63
Compare
|
|
||
| CONSTRAINT thread_subscriptions_fk_rooms | ||
| FOREIGN KEY (room_id) | ||
| REFERENCES rooms(room_id), |
There was a problem hiding this comment.
We'll need to delete from this during purge room
There was a problem hiding this comment.
do you think a ON DELETE CASCADE is fair here or do we need to be a bit more paginated about the deletion?
There was a problem hiding this comment.
oh, to be fair .... we will already delete subscriptions when the event is deleted, so when deleting the actual room there shouldn't be anything left to delete. In that case I think ON DELETE CASCADE is fair as a last-resort. I'll add that + a comment saying as much
reivilibre
force-pushed
the
rei/threads2_sub
branch
from
97ab7ea to
bc8bc50
Compare
erikjohnston
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: MSC4306 (partially)
Commit-by-commit review suggested.
What's missing:
Add
thread_subscriptionstableAdd stream backed by
thread_subscriptionstableAdd thread subscriptions handler
Add thread subscriptions endpoints
aside: note that EventID only applies to room versions 1 and 2
Add tests for thread subscription endpoints
docker workers: register thread_subscriptions worker as worker type