-
Notifications
You must be signed in to change notification settings - Fork 358
Add experimental and incomplete support for MSC4306: Thread Subscriptions. #18674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3f39f20
to
29d4fc3
Compare
82fc0d9
to
07bbbcf
Compare
fe2541b
to
79ecd7c
Compare
Signed-off-by: Olivier 'reivilibre <[email protected]>
79ecd7c
to
fdd1d63
Compare
|
||
CONSTRAINT thread_subscriptions_fk_rooms | ||
FOREIGN KEY (room_id) | ||
REFERENCES rooms(room_id), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to delete from this during purge room
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think a ON DELETE CASCADE
is fair here or do we need to be a bit more paginated about the deletion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, to be fair .... we will already delete subscriptions when the event is deleted, so when deleting the actual room there shouldn't be anything left to delete. In that case I think ON DELETE CASCADE
is fair as a last-resort. I'll add that + a comment saying as much
97ab7ea
to
bc8bc50
Compare
Implements: MSC4306 (partially)
Commit-by-commit review suggested.
What's missing:
Add
thread_subscriptions
tableAdd stream backed by
thread_subscriptions
tableAdd thread subscriptions handler
Add thread subscriptions endpoints
aside: note that EventID only applies to room versions 1 and 2
Add tests for thread subscription endpoints
docker workers: register thread_subscriptions worker as worker type