Add warning when implicitly casting maps/keywords to struct encode-time #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0idpwn
commented
May 3, 2025
v0idpwn
commented
May 3, 2025
yordis
reviewed
May 5, 2025
whatyouhide
reviewed
May 6, 2025
| @@ -309,6 +310,15 @@ defmodule Protobuf.EncoderTest do | |||
| end | |||
| end | |||
|
|
|||
| test "gives a warning for implicitly cast structs" do | |||
| warning = | |||
| ExUnit.CaptureIO.capture_io(:stderr, fn -> | |||
There was a problem hiding this comment.
This makes this test not really async-friendly anymore. Can we turn it to async: false and leave a comment up there explaining why (and maybe a TODO to turn it back async when we remove this warning)?
There was a problem hiding this comment.
Great point, added!
Co-authored-by: Andrea Leopardi <[email protected]>
Co-authored-by: Andrea Leopardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses discussion on #362.