Skip to content

Remove outdated / incorrect information on the initializers page #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NullVoxPopuli
Copy link
Contributor

implicit injections were deprecated long ago

Copy link

netlify bot commented Apr 25, 2025

Deploy Preview for ember-guides ready!

Name Link
🔨 Latest commit 059f852
🔍 Latest deploy log https://app.netlify.com/sites/ember-guides/deploys/680bd4975665d10008c685fa
😎 Deploy Preview https://deploy-preview-2108--ember-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johanrd
Copy link

johanrd commented Jun 10, 2025

@NullVoxPopuli the implicit injection part of this is outdated, perhaps, but are Application Initializers and Application Instance Initializers themselves deprecated?

I'm asking since I'm reporting ember deprecations to @sentry/ember, and there I also see they are using an instance initializer for sentry-performance.

Thanks,

@NullVoxPopuli
Copy link
Contributor Author

but are Application Initializers and Application Instance Initializers themselves deprecated?

they are not

also see they are using an

that is fine 🎉

@IgnaceMaes
Copy link
Member

While this does remove the outdated service injections, it makes the page incomplete about initializers itself. We could replace the injection bit with a different setup logic as example instead?

@NullVoxPopuli
Copy link
Contributor Author

sure, but I don't have the energy to write that rn. <3

@NullVoxPopuli
Copy link
Contributor Author

I would rather have incomplete docs than totally misleading ones 🙈

https://discord.com/channels/480462759797063690/480777444203429888/1386696245149434009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants