refactor: fix release guides minor double quotes in yml #2135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the version of the release guides minor script that exists in this repo looks for double quotes in the version.yml file and the script falls over.
We have a new release tool that probably should be preferred over the script internal to this repo https://github.com/ember-learn/guides-source, but since it appears that using that tool created a versions.yml without double quotes we are adapting to that format with the changes in this PR.
For reference here is the commit that changed the format of versions.yml
9632ba6#diff-7c320a9d771bef713f21002783458ef1a3221a465e43fd969da532e7e3bfd0f2