use relative imports inside ember-debug #2671
Conversation
mansona
force-pushed
the
relative-imports
branch
from
385086c to
e7dd425
Compare
| import DebugPort from './debug-port.js'; | ||
| import { compareVersion } from './utils/version'; |
There was a problem hiding this comment.
I can see that source ember-debug was changed to relative, and what was already relative now has the .js extension. But can you please remind me where the difference lies in the first place?
There was a problem hiding this comment.
to be perfectly honest I don't really know why some of them are .js and some have no extension 🤔 I'm pretty sure it's doing extension searching with @rollup/plugin-node-resolve in a similar way that node would.
Do you think we should remove or add the extensions? personally I think it's fine to mix and match 🤷
There was a problem hiding this comment.
it all gets rolled into one (or a few) file(s) anyway
There was a problem hiding this comment.
That's fine, my comment was not request change, just an honest question.
Description
This converts local imports inside ember-debug to use relative. I'm not exactly sure why it doesn't work very well but when we move to ESM (for top level await support) this breaks without relative imports 🤷
This PR essentially splits out the work to make the following change simpler 👍