Skip to content

Move benchmark to scripts. #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Move benchmark to scripts. #965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c2c23ff
Move benchmark to scripts.
T-256 Oct 9, 2024
86939e3
mypy
T-256 Oct 9, 2024
4644255
Merge branch 'master' into move-bench
lovelydinosaur Oct 12, 2024
bf7d216
Merge branch 'master' into move-bench
lovelydinosaur Apr 5, 2025
85ac7d4
Merge branch 'master' into move-bench
T-256 May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion httpcore/_backends/trio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def get_extra_info(self, info: str) -> typing.Any:
if info == "ssl_object" and isinstance(self._stream, trio.SSLStream):
# Type checkers cannot see `_ssl_object` attribute because trio._ssl.SSLStream uses __getattr__/__setattr__.
# Tracked at https://github.com/python-trio/trio/issues/542
return self._stream._ssl_object # type: ignore[attr-defined]
return self._stream._ssl_object
if info == "client_addr":
return self._get_socket_stream().socket.getsockname()
if info == "server_addr":
Expand Down
8 changes: 0 additions & 8 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,7 @@ twine==6.1.0
coverage[toml]==7.5.4
ruff==0.5.0
mypy==1.10.1
trio-typing==0.10.0
pytest==8.2.2
pytest-httpbin==2.0.0
pytest-trio==0.8.0
werkzeug<3.1 # See: https://github.com/psf/httpbin/issues/35

# Benchmarking and profiling
uvicorn==0.30.1
aiohttp==3.10.2
urllib3==2.2.2
matplotlib==3.7.5
pyinstrument==4.6.2
0 tests/benchmark/client.py → scripts/bench/client.py
View file
Open in desktop
File renamed without changes.
0 tests/benchmark/server.py → scripts/bench/server.py
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions scripts/benchmark
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ fi

set -x

${PREFIX}python tests/benchmark/server.py &
${PREFIX}python scripts/bench/server.py &
SERVER_PID=$!
EXIT_CODE=0
${PREFIX}python tests/benchmark/client.py "$@" || EXIT_CODE=$?
${PREFIX}python scripts/bench/client.py "$@" || EXIT_CODE=$?
kill $SERVER_PID
exit $EXIT_CODE